mirror of
https://github.com/minio/minio.git
synced 2024-12-25 06:35:56 -05:00
c82fa2c829
This PR also fixes issues when deletePolicy, deleteUser is idempotent so can lead to issues when client can prematurely timeout, so a retry call error response should be ignored when call returns http.StatusNotFound Fixes #9347
184 lines
4.9 KiB
Go
184 lines
4.9 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2019-2020 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*
|
|
*/
|
|
|
|
package madmin
|
|
|
|
import (
|
|
"context"
|
|
"math/rand"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
// MaxRetry is the maximum number of retries before stopping.
|
|
var MaxRetry = 10
|
|
|
|
// MaxJitter will randomize over the full exponential backoff time
|
|
const MaxJitter = 1.0
|
|
|
|
// NoJitter disables the use of jitter for randomizing the exponential backoff time
|
|
const NoJitter = 0.0
|
|
|
|
// DefaultRetryUnit - default unit multiplicative per retry.
|
|
// defaults to 1 second.
|
|
const DefaultRetryUnit = time.Second
|
|
|
|
// DefaultRetryCap - Each retry attempt never waits no longer than
|
|
// this maximum time duration.
|
|
const DefaultRetryCap = time.Second * 30
|
|
|
|
// lockedRandSource provides protected rand source, implements rand.Source interface.
|
|
type lockedRandSource struct {
|
|
lk sync.Mutex
|
|
src rand.Source
|
|
}
|
|
|
|
// Int63 returns a non-negative pseudo-random 63-bit integer as an int64.
|
|
func (r *lockedRandSource) Int63() (n int64) {
|
|
r.lk.Lock()
|
|
n = r.src.Int63()
|
|
r.lk.Unlock()
|
|
return
|
|
}
|
|
|
|
// Seed uses the provided seed value to initialize the generator to a
|
|
// deterministic state.
|
|
func (r *lockedRandSource) Seed(seed int64) {
|
|
r.lk.Lock()
|
|
r.src.Seed(seed)
|
|
r.lk.Unlock()
|
|
}
|
|
|
|
// newRetryTimer creates a timer with exponentially increasing
|
|
// delays until the maximum retry attempts are reached.
|
|
func (adm AdminClient) newRetryTimer(ctx context.Context, maxRetry int, unit time.Duration, cap time.Duration, jitter float64) <-chan int {
|
|
attemptCh := make(chan int)
|
|
|
|
// computes the exponential backoff duration according to
|
|
// https://www.awsarchitectureblog.com/2015/03/backoff.html
|
|
exponentialBackoffWait := func(attempt int) time.Duration {
|
|
// normalize jitter to the range [0, 1.0]
|
|
if jitter < NoJitter {
|
|
jitter = NoJitter
|
|
}
|
|
if jitter > MaxJitter {
|
|
jitter = MaxJitter
|
|
}
|
|
|
|
//sleep = random_between(0, min(cap, base * 2 ** attempt))
|
|
sleep := unit * time.Duration(1<<uint(attempt))
|
|
if sleep > cap {
|
|
sleep = cap
|
|
}
|
|
if jitter != NoJitter {
|
|
sleep -= time.Duration(adm.random.Float64() * float64(sleep) * jitter)
|
|
}
|
|
return sleep
|
|
}
|
|
|
|
go func() {
|
|
defer close(attemptCh)
|
|
for i := 0; i < maxRetry; i++ {
|
|
// Attempts start from 1.
|
|
select {
|
|
case attemptCh <- i + 1:
|
|
case <-ctx.Done():
|
|
// Stop the routine.
|
|
return
|
|
}
|
|
|
|
select {
|
|
case <-time.After(exponentialBackoffWait(i)):
|
|
case <-ctx.Done():
|
|
// Stop the routine.
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
return attemptCh
|
|
}
|
|
|
|
// isHTTPReqErrorRetryable - is http requests error retryable, such
|
|
// as i/o timeout, connection broken etc..
|
|
func isHTTPReqErrorRetryable(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
switch e := err.(type) {
|
|
case *url.Error:
|
|
switch e.Err.(type) {
|
|
case *net.DNSError, *net.OpError, net.UnknownNetworkError:
|
|
return true
|
|
}
|
|
if strings.Contains(err.Error(), "Connection closed by foreign host") {
|
|
return true
|
|
} else if strings.Contains(err.Error(), "net/http: TLS handshake timeout") {
|
|
// If error is - tlsHandshakeTimeoutError, retry.
|
|
return true
|
|
} else if strings.Contains(err.Error(), "i/o timeout") {
|
|
// If error is - tcp timeoutError, retry.
|
|
return true
|
|
} else if strings.Contains(err.Error(), "connection timed out") {
|
|
// If err is a net.Dial timeout, retry.
|
|
return true
|
|
} else if strings.Contains(err.Error(), "net/http: HTTP/1.x transport connection broken") {
|
|
// If error is transport connection broken, retry.
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// List of AWS S3 error codes which are retryable.
|
|
var retryableS3Codes = map[string]struct{}{
|
|
"RequestError": {},
|
|
"RequestTimeout": {},
|
|
"Throttling": {},
|
|
"ThrottlingException": {},
|
|
"RequestLimitExceeded": {},
|
|
"RequestThrottled": {},
|
|
"InternalError": {},
|
|
"SlowDown": {},
|
|
// Add more AWS S3 codes here.
|
|
}
|
|
|
|
// isS3CodeRetryable - is s3 error code retryable.
|
|
func isS3CodeRetryable(s3Code string) (ok bool) {
|
|
_, ok = retryableS3Codes[s3Code]
|
|
return ok
|
|
}
|
|
|
|
// List of HTTP status codes which are retryable.
|
|
var retryableHTTPStatusCodes = map[int]struct{}{
|
|
http.StatusRequestTimeout: {},
|
|
http.StatusTooManyRequests: {},
|
|
http.StatusInternalServerError: {},
|
|
http.StatusBadGateway: {},
|
|
http.StatusServiceUnavailable: {},
|
|
// Add more HTTP status codes here.
|
|
}
|
|
|
|
// isHTTPStatusRetryable - is HTTP error code retryable.
|
|
func isHTTPStatusRetryable(httpStatusCode int) (ok bool) {
|
|
_, ok = retryableHTTPStatusCodes[httpStatusCode]
|
|
return ok
|
|
}
|