mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
30d4a2cf53
Allow custom delimiters like `\r\n`, `a`, `\r` etc in input csv and replace with `\n`. Fixes #6403
84 lines
2.9 KiB
Go
84 lines
2.9 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017, 2018 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package ioutil
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Test for DelimitedCSVReader.
|
|
func TestDelimitedReader(t *testing.T) {
|
|
expected := "username,age\nbanana,12\ncarrot,23\napple,34\nbrinjal,90\nraddish,45"
|
|
|
|
inputs := []struct {
|
|
inputcsv string
|
|
delimiter string
|
|
chunkSize int
|
|
}{
|
|
// case 1 - with default `\n` delimiter.
|
|
{"username,age\nbanana,12\ncarrot,23\napple,34\nbrinjal,90\nraddish,45", "\n", 10},
|
|
// case 2 - with carriage return `\r` which should be replaced with `\n` by default.
|
|
{"username,age\rbanana,12\rcarrot,23\rapple,34\rbrinjal,90\rraddish,45", "\n", 10},
|
|
// case 3 - with a double character delimiter (octals).
|
|
{"username,age\r\nbanana,12\r\ncarrot,23\r\napple,34\r\nbrinjal,90\r\nraddish,45", "\r\n", 10},
|
|
// case 4 - with a double character delimiter.
|
|
{"username,agexvbanana,12xvcarrot,23xvapple,34xvbrinjal,90xvraddish,45", "xv", 10},
|
|
// case 5 - with a double character delimiter `\t `
|
|
{"username,age\t banana,12\t carrot,23\t apple,34\t brinjal,90\t raddish,45", "\t ", 10},
|
|
// case 6 - This is a special case where the first delimiter match falls in the 13'th byte space
|
|
// ie, the last byte space of the read chunk, In this case the reader should peek in the next byte
|
|
// and replace with `\n`.
|
|
{"username,agexxbanana,12xxcarrot,23xxapple,34xxbrinjal,90xxraddish,45", "xx", 13},
|
|
}
|
|
|
|
for c, input := range inputs {
|
|
var readcsv []byte
|
|
var err error
|
|
delimitedReader := NewDelimitedReader(strings.NewReader(input.inputcsv), []rune(input.delimiter))
|
|
for err == nil {
|
|
chunk := make([]byte, input.chunkSize)
|
|
_, err = delimitedReader.Read(chunk)
|
|
readcsv = append(readcsv, chunk...)
|
|
}
|
|
if err != io.EOF {
|
|
t.Fatalf("Case %d: Error in delimited read", c+1)
|
|
}
|
|
expected := []byte(expected)
|
|
cleanCsv := removeNulls(readcsv)
|
|
if !bytes.Equal(cleanCsv, expected) {
|
|
t.Fatalf("Case %d: Expected the delimited csv to be `%s`, but instead found `%s`", c+1, string(expected), string(cleanCsv))
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
// Removes all the tailing nulls in chunks.
|
|
// Null chunks will be assigned if there is a reduction
|
|
// Eg, When `xv` is reduced to `\n`, the last byte is nullified.
|
|
func removeNulls(csv []byte) []byte {
|
|
cleanCsv := []byte{}
|
|
for _, p := range csv {
|
|
if p != 0 {
|
|
cleanCsv = append(cleanCsv, p)
|
|
}
|
|
}
|
|
return cleanCsv
|
|
}
|