mirror of
https://github.com/minio/minio.git
synced 2024-12-26 23:25:54 -05:00
6c89a81af4
`(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`. The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`, which reads into an `ODirectPool` buffer. `(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading, the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused. However, if the async `Read` call unblocks, it will write to the now recycled buffer. Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts. This is not a disk timeout, anyway. Regression in https://github.com/minio/minio/pull/17745
207 lines
5.1 KiB
Go
207 lines
5.1 KiB
Go
// Copyright (c) 2015-2023 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package ioutil
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
type sleepWriter struct {
|
|
timeout time.Duration
|
|
}
|
|
|
|
func (w *sleepWriter) Write(p []byte) (n int, err error) {
|
|
time.Sleep(w.timeout)
|
|
return len(p), nil
|
|
}
|
|
|
|
func (w *sleepWriter) Close() error {
|
|
return nil
|
|
}
|
|
|
|
func TestDeadlineWriter(t *testing.T) {
|
|
w := NewDeadlineWriter(&sleepWriter{timeout: 500 * time.Millisecond}, 450*time.Millisecond)
|
|
_, err := w.Write([]byte("1"))
|
|
w.Close()
|
|
if err != context.DeadlineExceeded {
|
|
t.Error("DeadlineWriter shouldn't be successful - should return context.DeadlineExceeded")
|
|
}
|
|
_, err = w.Write([]byte("1"))
|
|
if err != context.DeadlineExceeded {
|
|
t.Error("DeadlineWriter shouldn't be successful - should return context.DeadlineExceeded")
|
|
}
|
|
w = NewDeadlineWriter(&sleepWriter{timeout: 100 * time.Millisecond}, 600*time.Millisecond)
|
|
n, err := w.Write([]byte("abcd"))
|
|
w.Close()
|
|
if err != nil {
|
|
t.Errorf("DeadlineWriter should succeed but failed with %s", err)
|
|
}
|
|
if n != 4 {
|
|
t.Errorf("DeadlineWriter should succeed but should have only written 4 bytes, but returned %d instead", n)
|
|
}
|
|
}
|
|
|
|
func TestCloseOnWriter(t *testing.T) {
|
|
writer := WriteOnClose(io.Discard)
|
|
if writer.HasWritten() {
|
|
t.Error("WriteOnCloser must not be marked as HasWritten")
|
|
}
|
|
writer.Write(nil)
|
|
if !writer.HasWritten() {
|
|
t.Error("WriteOnCloser must be marked as HasWritten")
|
|
}
|
|
|
|
writer = WriteOnClose(io.Discard)
|
|
writer.Close()
|
|
if !writer.HasWritten() {
|
|
t.Error("WriteOnCloser must be marked as HasWritten")
|
|
}
|
|
}
|
|
|
|
// Test for AppendFile.
|
|
func TestAppendFile(t *testing.T) {
|
|
f, err := os.CreateTemp("", "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
name1 := f.Name()
|
|
defer os.Remove(name1)
|
|
f.WriteString("aaaaaaaaaa")
|
|
f.Close()
|
|
|
|
f, err = os.CreateTemp("", "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
name2 := f.Name()
|
|
defer os.Remove(name2)
|
|
f.WriteString("bbbbbbbbbb")
|
|
f.Close()
|
|
|
|
if err = AppendFile(name1, name2, false); err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
b, err := os.ReadFile(name1)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
expected := "aaaaaaaaaabbbbbbbbbb"
|
|
if string(b) != expected {
|
|
t.Errorf("AppendFile() failed, expected: %s, got %s", expected, string(b))
|
|
}
|
|
}
|
|
|
|
func TestSkipReader(t *testing.T) {
|
|
testCases := []struct {
|
|
src io.Reader
|
|
skipLen int64
|
|
expected string
|
|
}{
|
|
{bytes.NewBuffer([]byte("")), 0, ""},
|
|
{bytes.NewBuffer([]byte("")), 1, ""},
|
|
{bytes.NewBuffer([]byte("abc")), 0, "abc"},
|
|
{bytes.NewBuffer([]byte("abc")), 1, "bc"},
|
|
{bytes.NewBuffer([]byte("abc")), 2, "c"},
|
|
{bytes.NewBuffer([]byte("abc")), 3, ""},
|
|
{bytes.NewBuffer([]byte("abc")), 4, ""},
|
|
}
|
|
for i, testCase := range testCases {
|
|
r := NewSkipReader(testCase.src, testCase.skipLen)
|
|
b, err := io.ReadAll(r)
|
|
if err != nil {
|
|
t.Errorf("Case %d: Unexpected err %v", i, err)
|
|
}
|
|
if string(b) != testCase.expected {
|
|
t.Errorf("Case %d: Got wrong result: %v", i, string(b))
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSameFile(t *testing.T) {
|
|
f, err := os.CreateTemp("", "")
|
|
if err != nil {
|
|
t.Errorf("Error creating tmp file: %v", err)
|
|
}
|
|
tmpFile := f.Name()
|
|
f.Close()
|
|
defer os.Remove(f.Name())
|
|
fi1, err := os.Stat(tmpFile)
|
|
if err != nil {
|
|
t.Fatalf("Error Stat(): %v", err)
|
|
}
|
|
fi2, err := os.Stat(tmpFile)
|
|
if err != nil {
|
|
t.Fatalf("Error Stat(): %v", err)
|
|
}
|
|
if !SameFile(fi1, fi2) {
|
|
t.Fatal("Expected the files to be same")
|
|
}
|
|
if err = os.WriteFile(tmpFile, []byte("aaa"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
fi2, err = os.Stat(tmpFile)
|
|
if err != nil {
|
|
t.Fatalf("Error Stat(): %v", err)
|
|
}
|
|
if SameFile(fi1, fi2) {
|
|
t.Fatal("Expected the files not to be same")
|
|
}
|
|
}
|
|
|
|
func TestCopyAligned(t *testing.T) {
|
|
f, err := os.CreateTemp("", "")
|
|
if err != nil {
|
|
t.Errorf("Error creating tmp file: %v", err)
|
|
}
|
|
defer f.Close()
|
|
defer os.Remove(f.Name())
|
|
|
|
r := strings.NewReader("hello world")
|
|
|
|
bufp := ODirectPoolSmall.Get().(*[]byte)
|
|
defer ODirectPoolSmall.Put(bufp)
|
|
|
|
written, err := CopyAligned(f, io.LimitReader(r, 5), *bufp, r.Size(), f)
|
|
if !errors.Is(err, io.ErrUnexpectedEOF) {
|
|
t.Errorf("Expected io.ErrUnexpectedEOF, but got %v", err)
|
|
}
|
|
if written != 5 {
|
|
t.Errorf("Expected written to be '5', but got %v", written)
|
|
}
|
|
|
|
f.Seek(0, io.SeekStart)
|
|
r.Seek(0, io.SeekStart)
|
|
|
|
written, err = CopyAligned(f, r, *bufp, r.Size(), f)
|
|
if !errors.Is(err, nil) {
|
|
t.Errorf("Expected nil, but got %v", err)
|
|
}
|
|
if written != r.Size() {
|
|
t.Errorf("Expected written to be '%v', but got %v", r.Size(), written)
|
|
}
|
|
}
|