mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
0a3b1ad4eb
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
240 lines
7.4 KiB
Go
240 lines
7.4 KiB
Go
//go:build linux
|
|
// +build linux
|
|
|
|
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package mountinfo
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Tests cross device mount verification function, for both failure
|
|
// and success cases.
|
|
func TestCrossDeviceMountPaths(t *testing.T) {
|
|
successCase := `/dev/0 /path/to/0/1 type0 flags 0 0
|
|
/dev/1 /path/to/1 type1 flags 1 1
|
|
/dev/2 /path/to/1/2 type2 flags,1,2=3 2 2
|
|
/dev/3 /path/to/1.1 type3 falgs,1,2=3 3 3
|
|
`
|
|
var err error
|
|
dir := t.TempDir()
|
|
mountsPath := filepath.Join(dir, "mounts")
|
|
if err = ioutil.WriteFile(mountsPath, []byte(successCase), 0o666); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Failure case where we detected successfully cross device mounts.
|
|
{
|
|
absPaths := []string{"/path/to/1"}
|
|
if err = checkCrossDevice(absPaths, mountsPath); err == nil {
|
|
t.Fatal("Expected to fail, but found success")
|
|
}
|
|
|
|
mp := []mountInfo{
|
|
{"/dev/2", "/path/to/1/2", "type2", []string{"flags"}, "2", "2"},
|
|
}
|
|
msg := fmt.Sprintf("Cross-device mounts detected on path (/path/to/1) at following locations %s. Export path should not have any sub-mounts, refusing to start.", mp)
|
|
if err.Error() != msg {
|
|
t.Fatalf("Expected msg %s, got %s", msg, err)
|
|
}
|
|
}
|
|
// Failure case when input path is not absolute.
|
|
{
|
|
absPaths := []string{"."}
|
|
if err = checkCrossDevice(absPaths, mountsPath); err == nil {
|
|
t.Fatal("Expected to fail for non absolute paths")
|
|
}
|
|
expectedErrMsg := fmt.Sprintf("Invalid argument, path (%s) is expected to be absolute", ".")
|
|
if err.Error() != expectedErrMsg {
|
|
t.Fatalf("Expected %s, got %s", expectedErrMsg, err)
|
|
}
|
|
}
|
|
// Success case, where path doesn't have any mounts.
|
|
{
|
|
absPaths := []string{"/path/to/x"}
|
|
if err = checkCrossDevice(absPaths, mountsPath); err != nil {
|
|
t.Fatalf("Expected success, failed instead (%s)", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests cross device mount verification function, for both failure
|
|
// and success cases.
|
|
func TestCrossDeviceMount(t *testing.T) {
|
|
successCase := `/dev/0 /path/to/0/1 type0 flags 0 0
|
|
/dev/1 /path/to/1 type1 flags 1 1
|
|
/dev/2 /path/to/1/2 type2 flags,1,2=3 2 2
|
|
/dev/3 /path/to/1.1 type3 falgs,1,2=3 3 3
|
|
`
|
|
var err error
|
|
dir := t.TempDir()
|
|
mountsPath := filepath.Join(dir, "mounts")
|
|
if err = ioutil.WriteFile(mountsPath, []byte(successCase), 0o666); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
mounts, err := readProcMounts(mountsPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Failure case where we detected successfully cross device mounts.
|
|
{
|
|
if err = mounts.checkCrossMounts("/path/to/1"); err == nil {
|
|
t.Fatal("Expected to fail, but found success")
|
|
}
|
|
|
|
mp := []mountInfo{
|
|
{"/dev/2", "/path/to/1/2", "type2", []string{"flags"}, "2", "2"},
|
|
}
|
|
msg := fmt.Sprintf("Cross-device mounts detected on path (/path/to/1) at following locations %s. Export path should not have any sub-mounts, refusing to start.", mp)
|
|
if err.Error() != msg {
|
|
t.Fatalf("Expected msg %s, got %s", msg, err)
|
|
}
|
|
}
|
|
// Failure case when input path is not absolute.
|
|
{
|
|
if err = mounts.checkCrossMounts("."); err == nil {
|
|
t.Fatal("Expected to fail for non absolute paths")
|
|
}
|
|
expectedErrMsg := fmt.Sprintf("Invalid argument, path (%s) is expected to be absolute", ".")
|
|
if err.Error() != expectedErrMsg {
|
|
t.Fatalf("Expected %s, got %s", expectedErrMsg, err)
|
|
}
|
|
}
|
|
// Success case, where path doesn't have any mounts.
|
|
{
|
|
if err = mounts.checkCrossMounts("/path/to/x"); err != nil {
|
|
t.Fatalf("Expected success, failed instead (%s)", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests read proc mounts file.
|
|
func TestReadProcmountInfos(t *testing.T) {
|
|
successCase := `/dev/0 /path/to/0 type0 flags 0 0
|
|
/dev/1 /path/to/1 type1 flags 1 1
|
|
/dev/2 /path/to/2 type2 flags,1,2=3 2 2
|
|
`
|
|
var err error
|
|
dir := t.TempDir()
|
|
|
|
mountsPath := filepath.Join(dir, "mounts")
|
|
if err = ioutil.WriteFile(mountsPath, []byte(successCase), 0o666); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Verifies if reading each line worked properly.
|
|
{
|
|
var mounts mountInfos
|
|
mounts, err = readProcMounts(mountsPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(mounts) != 3 {
|
|
t.Fatalf("expected 3 mounts, got %d", len(mounts))
|
|
}
|
|
mp := mountInfo{"/dev/0", "/path/to/0", "type0", []string{"flags"}, "0", "0"}
|
|
if !mountPointsEqual(mounts[0], mp) {
|
|
t.Errorf("got unexpected MountPoint[0]: %#v", mounts[0])
|
|
}
|
|
mp = mountInfo{"/dev/1", "/path/to/1", "type1", []string{"flags"}, "1", "1"}
|
|
if !mountPointsEqual(mounts[1], mp) {
|
|
t.Errorf("got unexpected mountInfo[1]: %#v", mounts[1])
|
|
}
|
|
mp = mountInfo{"/dev/2", "/path/to/2", "type2", []string{"flags", "1", "2=3"}, "2", "2"}
|
|
if !mountPointsEqual(mounts[2], mp) {
|
|
t.Errorf("got unexpected mountInfo[2]: %#v", mounts[2])
|
|
}
|
|
}
|
|
// Failure case mounts path doesn't exist, if not fail.
|
|
{
|
|
if _, err = readProcMounts(filepath.Join(dir, "non-existent")); err != nil && !os.IsNotExist(err) {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests read proc mounts reader.
|
|
func TestReadProcMountFrom(t *testing.T) {
|
|
successCase := `/dev/0 /path/to/0 type0 flags 0 0
|
|
/dev/1 /path/to/1 type1 flags 1 1
|
|
/dev/2 /path/to/2 type2 flags,1,2=3 2 2
|
|
`
|
|
// Success case, verifies if parsing works properly.
|
|
{
|
|
mounts, err := parseMountFrom(strings.NewReader(successCase))
|
|
if err != nil {
|
|
t.Errorf("expected success")
|
|
}
|
|
if len(mounts) != 3 {
|
|
t.Fatalf("expected 3 mounts, got %d", len(mounts))
|
|
}
|
|
mp := mountInfo{"/dev/0", "/path/to/0", "type0", []string{"flags"}, "0", "0"}
|
|
if !mountPointsEqual(mounts[0], mp) {
|
|
t.Errorf("got unexpected mountInfo[0]: %#v", mounts[0])
|
|
}
|
|
mp = mountInfo{"/dev/1", "/path/to/1", "type1", []string{"flags"}, "1", "1"}
|
|
if !mountPointsEqual(mounts[1], mp) {
|
|
t.Errorf("got unexpected mountInfo[1]: %#v", mounts[1])
|
|
}
|
|
mp = mountInfo{"/dev/2", "/path/to/2", "type2", []string{"flags", "1", "2=3"}, "2", "2"}
|
|
if !mountPointsEqual(mounts[2], mp) {
|
|
t.Errorf("got unexpected mountInfo[2]: %#v", mounts[2])
|
|
}
|
|
}
|
|
// Error cases where parsing fails with invalid Freq and Pass params.
|
|
{
|
|
errorCases := []string{
|
|
"/dev/1 /path/to/mount type flags a 0\n",
|
|
"/dev/2 /path/to/mount type flags 0 b\n",
|
|
}
|
|
for _, ec := range errorCases {
|
|
_, rerr := parseMountFrom(strings.NewReader(ec))
|
|
if rerr == nil {
|
|
t.Errorf("expected error")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Helpers for tests.
|
|
|
|
// Check if two `mountInfo` are equal.
|
|
func mountPointsEqual(a, b mountInfo) bool {
|
|
if a.Device != b.Device || a.Path != b.Path || a.FSType != b.FSType || !slicesEqual(a.Options, b.Options) || a.Pass != b.Pass || a.Freq != b.Freq {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// Checks if two string slices are equal.
|
|
func slicesEqual(a, b []string) bool {
|
|
if len(a) != len(b) {
|
|
return false
|
|
}
|
|
for i := range a {
|
|
if a[i] != b[i] {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|