mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
986aa8fabf
This makes lock RPCs similar to other RPCs where requests to the local server bypass the network. Requests to the local lock-subsystem may bypass the network layer and directly access the locking data-structures. This incidentally fixes #4451.
177 lines
5.0 KiB
Go
177 lines
5.0 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Test function to remove lock entries from map only in case they still exist based on name & uid combination
|
|
func TestLockRpcServerRemoveEntryIfExists(t *testing.T) {
|
|
testPath, locker, _ := createLockTestServer(t)
|
|
defer removeAll(testPath)
|
|
|
|
lri := lockRequesterInfo{
|
|
writer: false,
|
|
node: "host",
|
|
serviceEndpoint: "rpc-path",
|
|
uid: "0123-4567",
|
|
timestamp: UTCNow(),
|
|
timeLastCheck: UTCNow(),
|
|
}
|
|
nlrip := nameLockRequesterInfoPair{name: "name", lri: lri}
|
|
|
|
// first test by simulating item has already been deleted
|
|
locker.ll.removeEntryIfExists(nlrip)
|
|
{
|
|
gotLri, _ := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
|
|
// then test normal deletion
|
|
locker.ll.lockMap["name"] = []lockRequesterInfo{lri} // add item
|
|
locker.ll.removeEntryIfExists(nlrip)
|
|
{
|
|
gotLri, _ := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Test function to remove lock entries from map based on name & uid combination
|
|
func TestLockRpcServerRemoveEntry(t *testing.T) {
|
|
testPath, locker, _ := createLockTestServer(t)
|
|
defer removeAll(testPath)
|
|
|
|
lockRequesterInfo1 := lockRequesterInfo{
|
|
writer: true,
|
|
node: "host",
|
|
serviceEndpoint: "rpc-path",
|
|
uid: "0123-4567",
|
|
timestamp: UTCNow(),
|
|
timeLastCheck: UTCNow(),
|
|
}
|
|
lockRequesterInfo2 := lockRequesterInfo{
|
|
writer: true,
|
|
node: "host",
|
|
serviceEndpoint: "rpc-path",
|
|
uid: "89ab-cdef",
|
|
timestamp: UTCNow(),
|
|
timeLastCheck: UTCNow(),
|
|
}
|
|
|
|
locker.ll.lockMap["name"] = []lockRequesterInfo{
|
|
lockRequesterInfo1,
|
|
lockRequesterInfo2,
|
|
}
|
|
|
|
lri, _ := locker.ll.lockMap["name"]
|
|
|
|
// test unknown uid
|
|
if locker.ll.removeEntry("name", "unknown-uid", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", false, true)
|
|
}
|
|
|
|
if !locker.ll.removeEntry("name", "0123-4567", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", true, false)
|
|
} else {
|
|
gotLri, _ := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo{lockRequesterInfo2}
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
|
|
if !locker.ll.removeEntry("name", "89ab-cdef", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", true, false)
|
|
} else {
|
|
gotLri, _ := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests function returning long lived locks.
|
|
func TestLockRpcServerGetLongLivedLocks(t *testing.T) {
|
|
ut := UTCNow()
|
|
// Collection of test cases for verifying returning valid long lived locks.
|
|
testCases := []struct {
|
|
lockMap map[string][]lockRequesterInfo
|
|
lockInterval time.Duration
|
|
expectedNSLR []nameLockRequesterInfoPair
|
|
}{
|
|
// Testcase - 1 validates long lived locks, returns empty list.
|
|
{
|
|
lockMap: map[string][]lockRequesterInfo{
|
|
"test": {{
|
|
writer: true,
|
|
node: "10.1.10.21",
|
|
serviceEndpoint: "/lock/mnt/disk1",
|
|
uid: "10000112",
|
|
timestamp: ut,
|
|
timeLastCheck: ut,
|
|
}},
|
|
},
|
|
lockInterval: 1 * time.Minute,
|
|
expectedNSLR: []nameLockRequesterInfoPair{},
|
|
},
|
|
// Testcase - 2 validates long lived locks, returns at least one list.
|
|
{
|
|
lockMap: map[string][]lockRequesterInfo{
|
|
"test": {{
|
|
writer: true,
|
|
node: "10.1.10.21",
|
|
serviceEndpoint: "/lock/mnt/disk1",
|
|
uid: "10000112",
|
|
timestamp: ut,
|
|
timeLastCheck: ut.Add(-2 * time.Minute),
|
|
}},
|
|
},
|
|
lockInterval: 1 * time.Minute,
|
|
expectedNSLR: []nameLockRequesterInfoPair{
|
|
{
|
|
name: "test",
|
|
lri: lockRequesterInfo{
|
|
writer: true,
|
|
node: "10.1.10.21",
|
|
serviceEndpoint: "/lock/mnt/disk1",
|
|
uid: "10000112",
|
|
timestamp: ut,
|
|
timeLastCheck: ut.Add(-2 * time.Minute),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// Validates all test cases here.
|
|
for i, testCase := range testCases {
|
|
nsLR := getLongLivedLocks(testCase.lockMap, testCase.lockInterval)
|
|
if !reflect.DeepEqual(testCase.expectedNSLR, nsLR) {
|
|
t.Errorf("Test %d: Expected %#v, got %#v", i+1, testCase.expectedNSLR, nsLR)
|
|
}
|
|
}
|
|
}
|