mirror of
https://github.com/minio/minio.git
synced 2024-12-26 23:25:54 -05:00
0c31e61343
we have had numerous reports on some config values not having default values, causing features misbehaving and not having default values set properly. This PR tries to address all these concerns once and for all. Each new sub-system that gets added - must check for invalid keys - must have default values set - must not "return err" when being saved into a global state() instead collate as part of other subsystem errors allow other sub-systems to independently initialize.
191 lines
4.9 KiB
Go
191 lines
4.9 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package heal
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/minio/minio/internal/config"
|
|
"github.com/minio/pkg/v2/env"
|
|
)
|
|
|
|
// Compression environment variables
|
|
const (
|
|
Bitrot = "bitrotscan"
|
|
Sleep = "max_sleep"
|
|
IOCount = "max_io"
|
|
DriveWorkers = "drive_workers"
|
|
|
|
EnvBitrot = "MINIO_HEAL_BITROTSCAN"
|
|
EnvSleep = "MINIO_HEAL_MAX_SLEEP"
|
|
EnvIOCount = "MINIO_HEAL_MAX_IO"
|
|
EnvDriveWorkers = "MINIO_HEAL_DRIVE_WORKERS"
|
|
)
|
|
|
|
var configMutex sync.RWMutex
|
|
|
|
// Config represents the heal settings.
|
|
type Config struct {
|
|
// Bitrot will perform bitrot scan on local disk when checking objects.
|
|
Bitrot string `json:"bitrotscan"`
|
|
|
|
// maximum sleep duration between objects to slow down heal operation.
|
|
Sleep time.Duration `json:"sleep"`
|
|
IOCount int `json:"iocount"`
|
|
|
|
DriveWorkers int `json:"drive_workers"`
|
|
|
|
// Cached value from Bitrot field
|
|
cache struct {
|
|
// -1: bitrot enabled, 0: bitrot disabled, > 0: bitrot cycle
|
|
bitrotCycle time.Duration
|
|
}
|
|
}
|
|
|
|
// BitrotScanCycle returns the configured cycle for the scanner healing
|
|
// -1 for not enabled
|
|
//
|
|
// 0 for contiunous bitrot scanning
|
|
//
|
|
// >0 interval duration between cycles
|
|
func (opts Config) BitrotScanCycle() (d time.Duration) {
|
|
configMutex.RLock()
|
|
defer configMutex.RUnlock()
|
|
return opts.cache.bitrotCycle
|
|
}
|
|
|
|
// Clone safely the heal configuration
|
|
func (opts Config) Clone() (int, time.Duration, string) {
|
|
configMutex.RLock()
|
|
defer configMutex.RUnlock()
|
|
return opts.IOCount, opts.Sleep, opts.Bitrot
|
|
}
|
|
|
|
// GetWorkers returns the number of workers, -1 is none configured
|
|
func (opts Config) GetWorkers() int {
|
|
configMutex.RLock()
|
|
defer configMutex.RUnlock()
|
|
return opts.DriveWorkers
|
|
}
|
|
|
|
// Update updates opts with nopts
|
|
func (opts *Config) Update(nopts Config) {
|
|
configMutex.Lock()
|
|
defer configMutex.Unlock()
|
|
|
|
opts.Bitrot = nopts.Bitrot
|
|
opts.IOCount = nopts.IOCount
|
|
opts.Sleep = nopts.Sleep
|
|
opts.DriveWorkers = nopts.DriveWorkers
|
|
|
|
opts.cache.bitrotCycle, _ = parseBitrotConfig(nopts.Bitrot)
|
|
}
|
|
|
|
// DefaultKVS - default KV config for heal settings
|
|
var DefaultKVS = config.KVS{
|
|
config.KV{
|
|
Key: Bitrot,
|
|
Value: config.EnableOff,
|
|
},
|
|
config.KV{
|
|
Key: Sleep,
|
|
Value: "250ms",
|
|
},
|
|
config.KV{
|
|
Key: IOCount,
|
|
Value: "100",
|
|
},
|
|
config.KV{
|
|
Key: DriveWorkers,
|
|
Value: "",
|
|
},
|
|
}
|
|
|
|
const minimumBitrotCycleInMonths = 1
|
|
|
|
func parseBitrotConfig(s string) (time.Duration, error) {
|
|
// Try to parse as a boolean
|
|
enabled, err := config.ParseBool(s)
|
|
if err == nil {
|
|
switch enabled {
|
|
case true:
|
|
return 0, nil
|
|
case false:
|
|
return -1, nil
|
|
}
|
|
}
|
|
|
|
// Try to parse as a number of months
|
|
if !strings.HasSuffix(s, "m") {
|
|
return -1, errors.New("unknown format")
|
|
}
|
|
|
|
months, err := strconv.Atoi(strings.TrimSuffix(s, "m"))
|
|
if err != nil {
|
|
return -1, err
|
|
}
|
|
|
|
if months < minimumBitrotCycleInMonths {
|
|
return -1, fmt.Errorf("minimum bitrot cycle is %d month(s)", minimumBitrotCycleInMonths)
|
|
}
|
|
|
|
return time.Duration(months) * 30 * 24 * time.Hour, nil
|
|
}
|
|
|
|
// LookupConfig - lookup config and override with valid environment settings if any.
|
|
func LookupConfig(kvs config.KVS) (cfg Config, err error) {
|
|
if err = config.CheckValidKeys(config.HealSubSys, kvs, DefaultKVS); err != nil {
|
|
return cfg, err
|
|
}
|
|
|
|
bitrot := env.Get(EnvBitrot, kvs.GetWithDefault(Bitrot, DefaultKVS))
|
|
if _, err = parseBitrotConfig(bitrot); err != nil {
|
|
return cfg, fmt.Errorf("'heal:bitrotscan' value invalid: %w", err)
|
|
}
|
|
|
|
cfg.Bitrot = bitrot
|
|
|
|
cfg.Sleep, err = time.ParseDuration(env.Get(EnvSleep, kvs.GetWithDefault(Sleep, DefaultKVS)))
|
|
if err != nil {
|
|
return cfg, fmt.Errorf("'heal:max_sleep' value invalid: %w", err)
|
|
}
|
|
cfg.IOCount, err = strconv.Atoi(env.Get(EnvIOCount, kvs.GetWithDefault(IOCount, DefaultKVS)))
|
|
if err != nil {
|
|
return cfg, fmt.Errorf("'heal:max_io' value invalid: %w", err)
|
|
}
|
|
if ws := env.Get(EnvDriveWorkers, kvs.GetWithDefault(DriveWorkers, DefaultKVS)); ws != "" {
|
|
w, err := strconv.Atoi(ws)
|
|
if err != nil {
|
|
return cfg, fmt.Errorf("'heal:drive_workers' value invalid: %w", err)
|
|
}
|
|
if w < 1 {
|
|
return cfg, fmt.Errorf("'heal:drive_workers' value invalid: zero or negative integer unsupported")
|
|
}
|
|
cfg.DriveWorkers = w
|
|
} else {
|
|
cfg.DriveWorkers = -1
|
|
}
|
|
|
|
return cfg, nil
|
|
}
|