mirror of
https://github.com/minio/minio.git
synced 2024-12-27 15:45:55 -05:00
adca28801d
I have built a fuzz test and it crashes heavily in seconds and will OOM shortly after. It seems like supporting Parquet is basically a completely open way to crash the server if you can upload a file and run s3 select on it. Until Parquet is more hardened it is DISABLED by default since hostile crafted input can easily crash the server. If you are in a controlled environment where it is safe to assume no hostile content can be uploaded to your cluster you can safely enable Parquet. To enable Parquet set the environment variable `MINIO_API_SELECT_PARQUET=on` while starting the MinIO server. Furthermore, we guard parquet by recover functions.
122 lines
3.0 KiB
Go
122 lines
3.0 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2019 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package parquet
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/bcicen/jstream"
|
|
parquetgo "github.com/minio/minio/pkg/s3select/internal/parquet-go"
|
|
parquetgen "github.com/minio/minio/pkg/s3select/internal/parquet-go/gen-go/parquet"
|
|
jsonfmt "github.com/minio/minio/pkg/s3select/json"
|
|
"github.com/minio/minio/pkg/s3select/sql"
|
|
)
|
|
|
|
// Reader - Parquet record reader for S3Select.
|
|
type Reader struct {
|
|
args *ReaderArgs
|
|
reader *parquetgo.Reader
|
|
}
|
|
|
|
// Read - reads single record.
|
|
func (r *Reader) Read(dst sql.Record) (rec sql.Record, rerr error) {
|
|
defer func() {
|
|
if rec := recover(); rec != nil {
|
|
rerr = fmt.Errorf("panic reading parquet record: %v", rec)
|
|
}
|
|
}()
|
|
|
|
parquetRecord, err := r.reader.Read()
|
|
if err != nil {
|
|
if err != io.EOF {
|
|
return nil, errParquetParsingError(err)
|
|
}
|
|
|
|
return nil, err
|
|
}
|
|
|
|
kvs := jstream.KVS{}
|
|
f := func(name string, v parquetgo.Value) bool {
|
|
if v.Value == nil {
|
|
kvs = append(kvs, jstream.KV{Key: name, Value: nil})
|
|
return true
|
|
}
|
|
|
|
var value interface{}
|
|
switch v.Type {
|
|
case parquetgen.Type_BOOLEAN:
|
|
value = v.Value.(bool)
|
|
case parquetgen.Type_INT32:
|
|
value = int64(v.Value.(int32))
|
|
case parquetgen.Type_INT64:
|
|
value = int64(v.Value.(int64))
|
|
case parquetgen.Type_FLOAT:
|
|
value = float64(v.Value.(float32))
|
|
case parquetgen.Type_DOUBLE:
|
|
value = v.Value.(float64)
|
|
case parquetgen.Type_INT96, parquetgen.Type_BYTE_ARRAY, parquetgen.Type_FIXED_LEN_BYTE_ARRAY:
|
|
value = string(v.Value.([]byte))
|
|
default:
|
|
rerr = errParquetParsingError(nil)
|
|
return false
|
|
}
|
|
|
|
kvs = append(kvs, jstream.KV{Key: name, Value: value})
|
|
return true
|
|
}
|
|
|
|
// Apply our range
|
|
parquetRecord.Range(f)
|
|
|
|
// Reuse destination if we can.
|
|
dstRec, ok := dst.(*jsonfmt.Record)
|
|
if !ok {
|
|
dstRec = &jsonfmt.Record{}
|
|
}
|
|
dstRec.SelectFormat = sql.SelectFmtParquet
|
|
dstRec.KVS = kvs
|
|
return dstRec, nil
|
|
}
|
|
|
|
// Close - closes underlying readers.
|
|
func (r *Reader) Close() error {
|
|
return r.reader.Close()
|
|
}
|
|
|
|
// NewReader - creates new Parquet reader using readerFunc callback.
|
|
func NewReader(getReaderFunc func(offset, length int64) (io.ReadCloser, error), args *ReaderArgs) (r *Reader, err error) {
|
|
defer func() {
|
|
if rec := recover(); rec != nil {
|
|
err = fmt.Errorf("panic reading parquet header: %v", rec)
|
|
}
|
|
}()
|
|
reader, err := parquetgo.NewReader(getReaderFunc, nil)
|
|
if err != nil {
|
|
if err != io.EOF {
|
|
return nil, errParquetParsingError(err)
|
|
}
|
|
|
|
return nil, err
|
|
}
|
|
|
|
return &Reader{
|
|
args: args,
|
|
reader: reader,
|
|
}, nil
|
|
}
|