minio/internal
Klaus Post 6c89a81af4
Fix CreateFile shared buffer corruption. (#18652)
`(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`.

The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`, 
which reads into an `ODirectPool` buffer.

`(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading, 
the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused.

However, if the async `Read` call unblocks, it will write to the now recycled buffer.

Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts. 
This is not a disk timeout, anyway.

Regression in https://github.com/minio/minio/pull/17745
2023-12-14 10:51:57 -08:00
..
amztime fix: set time format right (#17402) 2023-06-14 07:49:13 -07:00
arn Allow OpenID ARN resource ID to start with a `-` (#18255) 2023-10-16 13:50:51 -07:00
auth Add "name" and "description" params to service acc (#17172) 2023-05-17 17:05:36 -07:00
bpool run gofumpt cleanup across code-base (#14015) 2022-01-02 09:15:06 -08:00
bucket ilm: ObjectSizeLessThan and ObjectSizeGreaterThan (#18500) 2023-11-22 13:42:39 -08:00
color log: Do not interpret verbs in object names in console output (#16233) 2022-12-13 08:27:40 -08:00
config yml-config: Add support of rootUser and rootPassword (#18615) 2023-12-08 12:04:54 -08:00
crypto Update to minio/pkg/v2 (#17967) 2023-09-04 12:57:37 -07:00
deadlineconn add deadlineConnections on remoteTransport (#16010) 2022-11-05 11:09:21 -07:00
disk fix: linter errors in Windows specific code (#18276) 2023-10-18 11:08:15 -07:00
dsync perf: websocket grid connectivity for all internode communication (#18461) 2023-11-20 17:09:35 -08:00
etag feat: SSE-KMS use uuid instead of read all data to md5. (#17958) 2023-09-18 10:00:54 -07:00
event Label the notification target metrics by their target IDs (#18633) 2023-12-14 09:09:26 -08:00
fips disable builds for go1.18 (#16332) 2022-12-30 11:37:07 -08:00
grid Truncate long traces for internode communication (#18593) 2023-12-05 12:16:48 -08:00
handlers lint: fix some lint issues on files 2023-04-06 22:42:10 -07:00
hash feat: SSE-KMS use uuid instead of read all data to md5. (#17958) 2023-09-18 10:00:54 -07:00
http Disable DMA optimization on windows (#18575) 2023-12-01 16:13:19 -08:00
init force all internal MinIO operations to be under UTC (#16009) 2022-11-04 16:44:38 -07:00
ioutil Fix CreateFile shared buffer corruption. (#18652) 2023-12-14 10:51:57 -08:00
jwt allow JWT parsing on large session policy based tokens (#17167) 2023-05-09 00:53:08 -07:00
kms Update to minio/pkg/v2 (#17967) 2023-09-04 12:57:37 -07:00
lock fix: linter errors in Windows specific code (#18276) 2023-10-18 11:08:15 -07:00
logger perf: websocket grid connectivity for all internode communication (#18461) 2023-11-20 17:09:35 -08:00
lsync cleanup Go linter settings (#16736) 2023-03-04 20:57:35 -08:00
mcontext Add X-Amz-Request-Id to internode calls (#16146) 2022-12-06 09:27:26 -08:00
mountinfo Remove deprecated io/ioutil (#15707) 2022-09-19 11:05:16 -07:00
net fix: return error when requested interface has no stats available (#17666) 2023-07-17 01:14:01 -07:00
once Support persistent queue store for loggers (#17121) 2023-05-08 21:20:31 -07:00
pubsub mark pubsub type safe via generics (#15961) 2022-10-28 10:55:42 -07:00
rest perf: websocket grid connectivity for all internode communication (#18461) 2023-11-20 17:09:35 -08:00
s3select replace io.Discard usage to fix some NUMA copy() latencies (#18394) 2023-11-06 14:26:08 -08:00
store Send kafka notification messages in batches when queue_dir is enabled (#18164) 2023-10-07 08:07:38 -07:00