mirror of
https://github.com/minio/minio.git
synced 2024-12-26 15:15:55 -05:00
f31a00de01
Traffic metering was not protected against concurrent updates.
```
WARNING: DATA RACE
Read at 0x00c02b0dace8 by goroutine 235:
github.com/minio/minio/cmd.setHTTPStatsHandler.func1()
d:/minio/minio/cmd/generic-handlers.go:360 +0x27d
net/http.HandlerFunc.ServeHTTP()
...
Previous write at 0x00c02b0dace8 by goroutine 994:
github.com/minio/minio/internal/http/stats.(*IncomingTrafficMeter).Read()
d:/minio/minio/internal/http/stats/http-traffic-recorder.go:34 +0xd2
```
68 lines
2.0 KiB
Go
68 lines
2.0 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package stats
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"sync/atomic"
|
|
)
|
|
|
|
// IncomingTrafficMeter counts the incoming bytes from the underlying request.Body.
|
|
type IncomingTrafficMeter struct {
|
|
countBytes int64
|
|
io.ReadCloser
|
|
}
|
|
|
|
// Read calls the underlying Read and counts the transferred bytes.
|
|
func (r *IncomingTrafficMeter) Read(p []byte) (n int, err error) {
|
|
n, err = r.ReadCloser.Read(p)
|
|
atomic.AddInt64(&r.countBytes, int64(n))
|
|
|
|
return n, err
|
|
}
|
|
|
|
// BytesCount returns the number of transferred bytes
|
|
func (r IncomingTrafficMeter) BytesCount() int64 {
|
|
return atomic.LoadInt64(&r.countBytes)
|
|
}
|
|
|
|
// OutgoingTrafficMeter counts the outgoing bytes through the responseWriter.
|
|
type OutgoingTrafficMeter struct {
|
|
countBytes int64
|
|
// wrapper for underlying http.ResponseWriter.
|
|
http.ResponseWriter
|
|
}
|
|
|
|
// Write calls the underlying write and counts the output bytes
|
|
func (w *OutgoingTrafficMeter) Write(p []byte) (n int, err error) {
|
|
n, err = w.ResponseWriter.Write(p)
|
|
atomic.AddInt64(&w.countBytes, int64(n))
|
|
return n, err
|
|
}
|
|
|
|
// Flush calls the underlying Flush.
|
|
func (w *OutgoingTrafficMeter) Flush() {
|
|
w.ResponseWriter.(http.Flusher).Flush()
|
|
}
|
|
|
|
// BytesCount returns the number of transferred bytes
|
|
func (w OutgoingTrafficMeter) BytesCount() int64 {
|
|
return atomic.LoadInt64(&w.countBytes)
|
|
}
|