mirror of
https://github.com/minio/minio.git
synced 2024-12-26 07:05:55 -05:00
f21d650ed4
This PR refactors the way we use buffers for O_DIRECT and to re-use those buffers for messagepack reader writer. After some extensive benchmarking found that not all objects have this benefit, and only objects smaller than 64KiB see this benefit overall. Benefits are seen from almost all objects from 1KiB - 32KiB Beyond this no objects see benefit with bulk call approach as the latency of bytes sent over the wire v/s streaming content directly from disk negate each other with no remarkable benefits. All other optimizations include reuse of msgp.Reader, msgp.Writer using sync.Pool's for all internode calls.
86 lines
2.0 KiB
Go
86 lines
2.0 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2018 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"io/ioutil"
|
|
"log"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func testBitrotReaderWriterAlgo(t *testing.T, bitrotAlgo BitrotAlgorithm) {
|
|
tmpDir, err := ioutil.TempDir("", "")
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
volume := "testvol"
|
|
filePath := "testfile"
|
|
|
|
disk, err := newLocalXLStorage(tmpDir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
disk.MakeVol(context.Background(), volume)
|
|
|
|
writer := newBitrotWriter(disk, volume, filePath, 35, bitrotAlgo, 10)
|
|
|
|
_, err = writer.Write([]byte("aaaaaaaaaa"))
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
_, err = writer.Write([]byte("aaaaaaaaaa"))
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
_, err = writer.Write([]byte("aaaaaaaaaa"))
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
_, err = writer.Write([]byte("aaaaa"))
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
writer.(io.Closer).Close()
|
|
|
|
reader := newBitrotReader(disk, nil, volume, filePath, 35, bitrotAlgo, bitrotWriterSum(writer), 10)
|
|
b := make([]byte, 10)
|
|
if _, err = reader.ReadAt(b, 0); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
if _, err = reader.ReadAt(b, 10); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
if _, err = reader.ReadAt(b, 20); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
if _, err = reader.ReadAt(b[:5], 30); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestAllBitrotAlgorithms(t *testing.T) {
|
|
for bitrotAlgo := range bitrotAlgorithms {
|
|
testBitrotReaderWriterAlgo(t, bitrotAlgo)
|
|
}
|
|
}
|