mirror of
https://github.com/minio/minio.git
synced 2024-12-25 06:35:56 -05:00
0104af6bcc
This is to ensure that Go contexts work properly, after some interesting experiments I found that Go net/http doesn't cancel the context when Body is non-zero and hasn't been read till EOF. The following gist explains this, this can lead to pile up of go-routines on the server which will never be canceled and will die at a really later point in time, which can simply overwhelm the server. https://gist.github.com/harshavardhana/c51dcfd055780eaeb71db54f9c589150 To avoid this refactor the locking such that we take locks after we have started reading from the body and only take locks when needed. Also, remove contextReader as it's not useful, doesn't work as expected context is not canceled until the body reaches EOF so there is no point in wrapping it with context and putting a `select {` on it which can unnecessarily increase the CPU overhead. We will still use the context to cancel the lockers etc. Additional simplification in the locker code to avoid timers as re-using them is a complicated ordeal avoid them in the hot path, since locking is very common this may avoid lots of allocations. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| drwmutex_test.go | ||
| drwmutex.go | ||
| dsync_test.go | ||
| dsync-server_test.go | ||
| dsync.go | ||
| rpc-client-impl_test.go | ||
| rpc-client-interface.go | ||