mirror of
https://github.com/minio/minio.git
synced 2024-12-26 07:05:55 -05:00
426c902b87
This PR changes the handling of bucket deletes for site replicated setups to hold on to deleted bucket state until it syncs to all the clusters participating in site replication.
123 lines
3.9 KiB
Go
123 lines
3.9 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"crypto/md5"
|
|
"encoding/hex"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Wrapper for calling DeleteObject tests for both Erasure multiple disks and single node setup.
|
|
func TestDeleteObject(t *testing.T) {
|
|
ExecObjectLayerTest(t, testDeleteObject)
|
|
}
|
|
|
|
// Unit test for DeleteObject in general.
|
|
func testDeleteObject(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
type objectUpload struct {
|
|
name string
|
|
content string
|
|
}
|
|
|
|
testCases := []struct {
|
|
bucketName string
|
|
objectToUploads []objectUpload
|
|
pathToDelete string
|
|
objectsAfterDelete []string
|
|
}{
|
|
// Test 1: removes an object and checks it is the only object
|
|
// that has been deleted.
|
|
{
|
|
"bucket1",
|
|
[]objectUpload{{"object0", "content"}, {"object1", "content"}},
|
|
"object0",
|
|
[]string{"object1"},
|
|
},
|
|
// Test 2: remove an object inside a directory and checks it is deleted
|
|
// with its parent since this former becomes empty
|
|
{
|
|
"bucket2",
|
|
[]objectUpload{{"object0", "content"}, {"dir/object1", "content"}},
|
|
"dir/object1",
|
|
[]string{"object0"},
|
|
},
|
|
// Test 3: remove an object inside a directory and checks if it is deleted
|
|
// but other sibling object in the same directory still exists
|
|
{
|
|
"bucket3",
|
|
[]objectUpload{{"dir/object1", "content"}, {"dir/object2", "content"}},
|
|
"dir/object1",
|
|
[]string{"dir/object2"},
|
|
},
|
|
// Test 4: remove a non empty directory and checks it has no effect
|
|
{
|
|
"bucket4",
|
|
[]objectUpload{{"object0", "content"}, {"dir/object1", "content"}},
|
|
"dir/",
|
|
[]string{"dir/object1", "object0"},
|
|
},
|
|
// Test 5: Remove an empty directory and checks it is really removed
|
|
{
|
|
"bucket5",
|
|
[]objectUpload{{"object0", "content"}, {"dir/", ""}},
|
|
"dir/",
|
|
[]string{"object0"},
|
|
},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
err := obj.MakeBucketWithLocation(context.Background(), testCase.bucketName, MakeBucketOptions{})
|
|
if err != nil {
|
|
t.Fatalf("%s : %s", instanceType, err.Error())
|
|
}
|
|
|
|
for _, object := range testCase.objectToUploads {
|
|
md5Bytes := md5.Sum([]byte(object.content))
|
|
oi, err := obj.PutObject(context.Background(), testCase.bucketName, object.name, mustGetPutObjReader(t, strings.NewReader(object.content),
|
|
int64(len(object.content)), hex.EncodeToString(md5Bytes[:]), ""), ObjectOptions{})
|
|
t.Log(oi)
|
|
if err != nil {
|
|
t.Fatalf("%s : %s", instanceType, err.Error())
|
|
}
|
|
}
|
|
|
|
oi, err := obj.DeleteObject(context.Background(), testCase.bucketName, testCase.pathToDelete, ObjectOptions{})
|
|
t.Log(oi, err)
|
|
|
|
result, err := obj.ListObjects(context.Background(), testCase.bucketName, "", "", "", 1000)
|
|
if err != nil {
|
|
t.Errorf("Test %d: %s: Expected to pass, but failed with: <ERROR> %s", i+1, instanceType, err.Error())
|
|
continue
|
|
}
|
|
|
|
if len(result.Objects) != len(testCase.objectsAfterDelete) {
|
|
t.Errorf("Test %d: %s: mismatch number of objects after delete, expected = %v, found = %v", i+1, instanceType, testCase.objectsAfterDelete, result.Objects)
|
|
continue
|
|
}
|
|
|
|
for idx := range result.Objects {
|
|
if result.Objects[idx].Name != testCase.objectsAfterDelete[idx] {
|
|
t.Errorf("Test %d: %s: Unexpected object found after delete, found = `%v`", i+1, instanceType, result.Objects[idx].Name)
|
|
}
|
|
}
|
|
}
|
|
}
|