mirror of
https://github.com/minio/minio.git
synced 2024-12-27 23:55:56 -05:00
7e1661f4fa
This improves the performance of certain queries dramatically, such as 'count(*)' etc. Without this PR ``` ~ time mc select --query "select count(*) from S3Object" myminio/sjm-airlines/star2000.csv.gz 2173762 real 0m42.464s user 0m0.071s sys 0m0.010s ``` With this PR ``` ~ time mc select --query "select count(*) from S3Object" myminio/sjm-airlines/star2000.csv.gz 2173762 real 0m17.603s user 0m0.093s sys 0m0.008s ``` Almost a 250% improvement in performance. This PR avoids a lot of type conversions and instead relies on raw sequences of data and interprets them lazily. ``` benchcmp old new benchmark old ns/op new ns/op delta BenchmarkSQLAggregate_100K-4 551213 259782 -52.87% BenchmarkSQLAggregate_1M-4 6981901985 2432413729 -65.16% BenchmarkSQLAggregate_2M-4 13511978488 4536903552 -66.42% BenchmarkSQLAggregate_10M-4 68427084908 23266283336 -66.00% benchmark old allocs new allocs delta BenchmarkSQLAggregate_100K-4 2366 485 -79.50% BenchmarkSQLAggregate_1M-4 47455492 21462860 -54.77% BenchmarkSQLAggregate_2M-4 95163637 43110771 -54.70% BenchmarkSQLAggregate_10M-4 476959550 216906510 -54.52% benchmark old bytes new bytes delta BenchmarkSQLAggregate_100K-4 1233079 1086024 -11.93% BenchmarkSQLAggregate_1M-4 2607984120 557038536 -78.64% BenchmarkSQLAggregate_2M-4 5254103616 1128149168 -78.53% BenchmarkSQLAggregate_10M-4 26443524872 5722715992 -78.36% ```
564 lines
17 KiB
Go
564 lines
17 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2018 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package s3select
|
|
|
|
import (
|
|
"fmt"
|
|
"math"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/minio/minio/pkg/s3select/format"
|
|
"github.com/tidwall/gjson"
|
|
"github.com/xwb1989/sqlparser"
|
|
)
|
|
|
|
// MaxExpressionLength - 256KiB
|
|
const MaxExpressionLength = 256 * 1024
|
|
|
|
// matchesMyWhereClause takes []byte, process the where clause and returns true if the row suffices
|
|
func matchesMyWhereClause(record []byte, alias string, whereClause sqlparser.Expr) (bool, error) {
|
|
var conversionColumn string
|
|
var operator string
|
|
var operand gjson.Result
|
|
if fmt.Sprintf("%v", whereClause) == "false" {
|
|
return false, nil
|
|
}
|
|
switch expr := whereClause.(type) {
|
|
case *sqlparser.IsExpr:
|
|
return evaluateIsExpr(expr, record, alias)
|
|
case *sqlparser.RangeCond:
|
|
operator = expr.Operator
|
|
if operator != "between" && operator != "not between" {
|
|
return false, ErrUnsupportedSQLOperation
|
|
}
|
|
result, err := evaluateBetween(expr, alias, record)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if operator == "not between" {
|
|
return !result, nil
|
|
}
|
|
return result, nil
|
|
case *sqlparser.ComparisonExpr:
|
|
operator = expr.Operator
|
|
switch right := expr.Right.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
operand = gjson.Parse(evaluateFuncExpr(right, "", record))
|
|
case *sqlparser.SQLVal:
|
|
operand = gjson.ParseBytes(right.Val)
|
|
}
|
|
var myVal string
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
myVal = evaluateFuncExpr(left, "", record)
|
|
conversionColumn = ""
|
|
case *sqlparser.ColName:
|
|
conversionColumn = left.Name.CompliantName()
|
|
}
|
|
if myVal != "" {
|
|
return evaluateOperator(gjson.Parse(myVal), operator, operand)
|
|
}
|
|
return evaluateOperator(gjson.GetBytes(record, conversionColumn), operator, operand)
|
|
case *sqlparser.AndExpr:
|
|
var leftVal bool
|
|
var rightVal bool
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
temp, err := matchesMyWhereClause(record, alias, left)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
leftVal = temp
|
|
}
|
|
switch right := expr.Right.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
temp, err := matchesMyWhereClause(record, alias, right)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
rightVal = temp
|
|
}
|
|
return (rightVal && leftVal), nil
|
|
case *sqlparser.OrExpr:
|
|
var leftVal bool
|
|
var rightVal bool
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
leftVal, _ = matchesMyWhereClause(record, alias, left)
|
|
|
|
}
|
|
switch right := expr.Right.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
rightVal, _ = matchesMyWhereClause(record, alias, right)
|
|
}
|
|
return (rightVal || leftVal), nil
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
func applyStrFunc(rawArg gjson.Result, funcName string) string {
|
|
switch strings.ToUpper(funcName) {
|
|
case "TRIM":
|
|
// parser has an issue which does not allow it to support
|
|
// Trim with other arguments
|
|
return strings.Trim(rawArg.String(), " ")
|
|
case "SUBSTRING":
|
|
// TODO: parser has an issue which does not support substring
|
|
return rawArg.String()
|
|
case "CHAR_LENGTH":
|
|
return strconv.Itoa(len(rawArg.String()))
|
|
case "CHARACTER_LENGTH":
|
|
return strconv.Itoa(len(rawArg.String()))
|
|
case "LOWER":
|
|
return strings.ToLower(rawArg.String())
|
|
case "UPPER":
|
|
return strings.ToUpper(rawArg.String())
|
|
}
|
|
return rawArg.String()
|
|
|
|
}
|
|
|
|
// evaluateBetween is a function which evaluates a Between Clause.
|
|
func evaluateBetween(betweenExpr *sqlparser.RangeCond, alias string, record []byte) (bool, error) {
|
|
var colToVal gjson.Result
|
|
var colFromVal gjson.Result
|
|
var conversionColumn string
|
|
var funcName string
|
|
switch colTo := betweenExpr.To.(type) {
|
|
case sqlparser.Expr:
|
|
switch colToMyVal := colTo.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
colToVal = gjson.Parse(stringOps(colToMyVal, record, ""))
|
|
case *sqlparser.SQLVal:
|
|
colToVal = gjson.ParseBytes(colToMyVal.Val)
|
|
}
|
|
}
|
|
switch colFrom := betweenExpr.From.(type) {
|
|
case sqlparser.Expr:
|
|
switch colFromMyVal := colFrom.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
colFromVal = gjson.Parse(stringOps(colFromMyVal, record, ""))
|
|
case *sqlparser.SQLVal:
|
|
colFromVal = gjson.ParseBytes(colFromMyVal.Val)
|
|
}
|
|
}
|
|
var myFuncVal string
|
|
switch left := betweenExpr.Left.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
myFuncVal = evaluateFuncExpr(left, "", record)
|
|
conversionColumn = ""
|
|
case *sqlparser.ColName:
|
|
conversionColumn = cleanCol(left.Name.CompliantName(), alias)
|
|
}
|
|
toGreater, err := evaluateOperator(colToVal, ">", colFromVal)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if toGreater {
|
|
return evalBetweenGreater(conversionColumn, record, funcName, colFromVal, colToVal, myFuncVal)
|
|
}
|
|
return evalBetweenLess(conversionColumn, record, funcName, colFromVal, colToVal, myFuncVal)
|
|
}
|
|
|
|
func evalBetween(conversionColumn string, record []byte, funcName string, colFromVal gjson.Result, colToVal gjson.Result, myColVal string, operator string) (bool, error) {
|
|
if format.IsInt(conversionColumn) {
|
|
myVal, err := evaluateOperator(gjson.GetBytes(record, "_"+conversionColumn), operator, colFromVal)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
var myOtherVal bool
|
|
myOtherVal, err = evaluateOperator(colToVal, operator, gjson.GetBytes(record, "_"+conversionColumn))
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return (myVal && myOtherVal), nil
|
|
}
|
|
if myColVal != "" {
|
|
myVal, err := evaluateOperator(gjson.Parse(myColVal), operator, colFromVal)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
var myOtherVal bool
|
|
myOtherVal, err = evaluateOperator(colToVal, operator, gjson.Parse(myColVal))
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return (myVal && myOtherVal), nil
|
|
}
|
|
myVal, err := evaluateOperator(gjson.GetBytes(record, conversionColumn), operator, colFromVal)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
var myOtherVal bool
|
|
myOtherVal, err = evaluateOperator(colToVal, operator, gjson.GetBytes(record, conversionColumn))
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return (myVal && myOtherVal), nil
|
|
}
|
|
|
|
// evalBetweenGreater is a function which evaluates the between given that the
|
|
// TO is > than the FROM.
|
|
func evalBetweenGreater(conversionColumn string, record []byte, funcName string, colFromVal gjson.Result, colToVal gjson.Result, myColVal string) (bool, error) {
|
|
return evalBetween(conversionColumn, record, funcName, colFromVal, colToVal, myColVal, ">=")
|
|
}
|
|
|
|
// evalBetweenLess is a function which evaluates the between given that the
|
|
// FROM is > than the TO.
|
|
func evalBetweenLess(conversionColumn string, record []byte, funcName string, colFromVal gjson.Result, colToVal gjson.Result, myColVal string) (bool, error) {
|
|
return evalBetween(conversionColumn, record, funcName, colFromVal, colToVal, myColVal, "<=")
|
|
}
|
|
|
|
// This is a really important function it actually evaluates the boolean
|
|
// statement and therefore actually returns a bool, it functions as the lowest
|
|
// level of the state machine.
|
|
func evaluateOperator(myTblVal gjson.Result, operator string, operand gjson.Result) (bool, error) {
|
|
if err := checkValidOperator(operator); err != nil {
|
|
return false, err
|
|
}
|
|
if !myTblVal.Exists() {
|
|
return false, nil
|
|
}
|
|
switch {
|
|
case operand.Type == gjson.String || operand.Type == gjson.Null:
|
|
return stringEval(myTblVal.String(), operator, operand.String())
|
|
case operand.Type == gjson.Number:
|
|
opInt := format.IsInt(operand.Raw)
|
|
tblValInt := format.IsInt(strings.Trim(myTblVal.Raw, "\""))
|
|
if opInt && tblValInt {
|
|
return intEval(int64(myTblVal.Float()), operator, operand.Int())
|
|
}
|
|
if !opInt && !tblValInt {
|
|
return floatEval(myTblVal.Float(), operator, operand.Float())
|
|
}
|
|
switch operator {
|
|
case "!=":
|
|
return true, nil
|
|
}
|
|
return false, nil
|
|
case myTblVal.Type != operand.Type:
|
|
return false, nil
|
|
default:
|
|
return false, ErrUnsupportedSyntax
|
|
}
|
|
}
|
|
|
|
// checkValidOperator ensures that the current operator is supported
|
|
func checkValidOperator(operator string) error {
|
|
listOfOps := []string{">", "<", "=", "<=", ">=", "!=", "like"}
|
|
for i := range listOfOps {
|
|
if operator == listOfOps[i] {
|
|
return nil
|
|
}
|
|
}
|
|
return ErrParseUnknownOperator
|
|
}
|
|
|
|
// stringEval is for evaluating the state of string comparison.
|
|
func stringEval(myRecordVal string, operator string, myOperand string) (bool, error) {
|
|
switch operator {
|
|
case ">":
|
|
return myRecordVal > myOperand, nil
|
|
case "<":
|
|
return myRecordVal < myOperand, nil
|
|
case "=":
|
|
return myRecordVal == myOperand, nil
|
|
case "<=":
|
|
return myRecordVal <= myOperand, nil
|
|
case ">=":
|
|
return myRecordVal >= myOperand, nil
|
|
case "!=":
|
|
return myRecordVal != myOperand, nil
|
|
case "like":
|
|
return likeConvert(myOperand, myRecordVal)
|
|
}
|
|
return false, ErrUnsupportedSyntax
|
|
}
|
|
|
|
// intEval is for evaluating integer comparisons.
|
|
func intEval(myRecordVal int64, operator string, myOperand int64) (bool, error) {
|
|
|
|
switch operator {
|
|
case ">":
|
|
return myRecordVal > myOperand, nil
|
|
case "<":
|
|
return myRecordVal < myOperand, nil
|
|
case "=":
|
|
return myRecordVal == myOperand, nil
|
|
case "<=":
|
|
return myRecordVal <= myOperand, nil
|
|
case ">=":
|
|
return myRecordVal >= myOperand, nil
|
|
case "!=":
|
|
return myRecordVal != myOperand, nil
|
|
}
|
|
return false, ErrUnsupportedSyntax
|
|
}
|
|
|
|
// floatEval is for evaluating the comparison of floats.
|
|
func floatEval(myRecordVal float64, operator string, myOperand float64) (bool, error) {
|
|
// Basically need some logic thats like, if the types dont match check for a cast
|
|
switch operator {
|
|
case ">":
|
|
return myRecordVal > myOperand, nil
|
|
case "<":
|
|
return myRecordVal < myOperand, nil
|
|
case "=":
|
|
return myRecordVal == myOperand, nil
|
|
case "<=":
|
|
return myRecordVal <= myOperand, nil
|
|
case ">=":
|
|
return myRecordVal >= myOperand, nil
|
|
case "!=":
|
|
return myRecordVal != myOperand, nil
|
|
}
|
|
return false, ErrUnsupportedSyntax
|
|
}
|
|
|
|
// prefixMatch allows for matching a prefix only like query e.g a%
|
|
func prefixMatch(pattern string, record string) bool {
|
|
for i := 0; i < len(pattern)-1; i++ {
|
|
if pattern[i] != record[i] && pattern[i] != byte('_') {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
// suffixMatch allows for matching a suffix only like query e.g %an
|
|
func suffixMatch(pattern string, record string) bool {
|
|
for i := len(pattern) - 1; i > 0; i-- {
|
|
if pattern[i] != record[len(record)-(len(pattern)-i)] && pattern[i] != byte('_') {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
// This function is for evaluating select statements which are case sensitive
|
|
func likeConvert(pattern string, record string) (bool, error) {
|
|
// If pattern is empty just return false
|
|
if pattern == "" || record == "" {
|
|
return false, nil
|
|
}
|
|
// for suffix match queries e.g %a
|
|
if len(pattern) >= 2 && pattern[0] == byte('%') && strings.Count(pattern, "%") == 1 {
|
|
return suffixMatch(pattern, record), nil
|
|
}
|
|
// for prefix match queries e.g a%
|
|
if len(pattern) >= 2 && pattern[len(pattern)-1] == byte('%') && strings.Count(pattern, "%") == 1 {
|
|
return prefixMatch(pattern, record), nil
|
|
}
|
|
charCount := 0
|
|
currPos := 0
|
|
// Loop through the pattern so that a boolean can be returned
|
|
for i := 0; i < len(pattern); i++ {
|
|
if pattern[i] == byte('_') {
|
|
// if its an underscore it can be anything so shift current position for
|
|
// pattern and string
|
|
charCount++
|
|
// if there have been more characters in the pattern than record, clearly
|
|
// there should be a return
|
|
if i != len(pattern)-1 {
|
|
if pattern[i+1] != byte('%') && pattern[i+1] != byte('_') {
|
|
if currPos != len(record)-1 && pattern[i+1] != record[currPos+1] {
|
|
return false, nil
|
|
}
|
|
}
|
|
}
|
|
if charCount > len(record) {
|
|
return false, nil
|
|
}
|
|
// if the pattern has been fully evaluated, then just return.
|
|
if len(pattern) == i+1 {
|
|
return true, nil
|
|
}
|
|
i++
|
|
currPos++
|
|
}
|
|
if pattern[i] == byte('%') || pattern[i] == byte('*') {
|
|
// if there is a wildcard then want to return true if its last and flag it.
|
|
if currPos == len(record) {
|
|
return false, nil
|
|
}
|
|
if i+1 == len(pattern) {
|
|
return true, nil
|
|
}
|
|
} else {
|
|
charCount++
|
|
matched := false
|
|
// iterate through the pattern and check if there is a match for the
|
|
// character
|
|
for currPos < len(record) {
|
|
if record[currPos] == pattern[i] || pattern[i] == byte('_') {
|
|
matched = true
|
|
break
|
|
}
|
|
currPos++
|
|
}
|
|
currPos++
|
|
// if the character did not match then return should occur.
|
|
if !matched {
|
|
return false, nil
|
|
}
|
|
}
|
|
}
|
|
if charCount > len(record) {
|
|
return false, nil
|
|
}
|
|
if currPos < len(record) {
|
|
return false, nil
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
// cleanCol cleans a column name from the parser so that the name is returned to
|
|
// original.
|
|
func cleanCol(myCol string, alias string) string {
|
|
if len(myCol) <= 0 {
|
|
return myCol
|
|
}
|
|
if !strings.HasPrefix(myCol, alias) && myCol[0] == '_' {
|
|
myCol = alias + myCol
|
|
}
|
|
|
|
if strings.Contains(myCol, ".") {
|
|
myCol = strings.Replace(myCol, alias+"._", "", len(myCol))
|
|
}
|
|
myCol = strings.Replace(myCol, alias+"_", "", len(myCol))
|
|
return myCol
|
|
}
|
|
|
|
// whereClauseNameErrs is a function which returns an error if there is a column
|
|
// in the where clause which does not exist.
|
|
func whereClauseNameErrs(whereClause interface{}, alias string, f format.Select) error {
|
|
var conversionColumn string
|
|
switch expr := whereClause.(type) {
|
|
// case for checking errors within a clause of the form "col_name is ..."
|
|
case *sqlparser.IsExpr:
|
|
switch myCol := expr.Expr.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
if err := evaluateFuncErr(myCol, f); err != nil {
|
|
return err
|
|
}
|
|
case *sqlparser.ColName:
|
|
conversionColumn = cleanCol(myCol.Name.CompliantName(), alias)
|
|
}
|
|
case *sqlparser.RangeCond:
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
if err := evaluateFuncErr(left, f); err != nil {
|
|
return err
|
|
}
|
|
case *sqlparser.ColName:
|
|
conversionColumn = cleanCol(left.Name.CompliantName(), alias)
|
|
}
|
|
case *sqlparser.ComparisonExpr:
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.FuncExpr:
|
|
if err := evaluateFuncErr(left, f); err != nil {
|
|
return err
|
|
}
|
|
case *sqlparser.ColName:
|
|
conversionColumn = cleanCol(left.Name.CompliantName(), alias)
|
|
}
|
|
case *sqlparser.AndExpr:
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
return whereClauseNameErrs(left, alias, f)
|
|
}
|
|
switch right := expr.Right.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
return whereClauseNameErrs(right, alias, f)
|
|
}
|
|
case *sqlparser.OrExpr:
|
|
switch left := expr.Left.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
return whereClauseNameErrs(left, alias, f)
|
|
}
|
|
switch right := expr.Right.(type) {
|
|
case *sqlparser.ComparisonExpr:
|
|
return whereClauseNameErrs(right, alias, f)
|
|
}
|
|
}
|
|
if conversionColumn != "" {
|
|
return f.ColNameErrs([]string{conversionColumn})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// aggFuncToStr converts an array of floats into a properly formatted string.
|
|
func aggFuncToStr(aggVals []float64, f format.Select) string {
|
|
// Define a number formatting function
|
|
numToStr := func(f float64) string {
|
|
if f == math.Trunc(f) {
|
|
return strconv.FormatInt(int64(f), 10)
|
|
}
|
|
return strconv.FormatFloat(f, 'f', 6, 64)
|
|
}
|
|
|
|
// Display all whole numbers in aggVals as integers
|
|
vals := make([]string, len(aggVals))
|
|
for i, v := range aggVals {
|
|
vals[i] = numToStr(v)
|
|
}
|
|
|
|
// Intersperse field delimiter
|
|
return strings.Join(vals, f.OutputFieldDelimiter())
|
|
}
|
|
|
|
// checkForDuplicates ensures we do not have an ambigious column name.
|
|
func checkForDuplicates(columns []string, columnsMap map[string]int) error {
|
|
for i, column := range columns {
|
|
columns[i] = strings.Replace(column, " ", "_", len(column))
|
|
if _, exist := columnsMap[columns[i]]; exist {
|
|
return ErrAmbiguousFieldName
|
|
}
|
|
columnsMap[columns[i]] = i
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// parseErrs is the function which handles all the errors that could occur
|
|
// through use of function arguments such as column names in NULLIF
|
|
func parseErrs(columnNames []string, whereClause interface{}, alias string, myFuncs SelectFuncs, f format.Select) error {
|
|
// Below code cleans up column names.
|
|
processColumnNames(columnNames, alias, f)
|
|
if columnNames[0] != "*" {
|
|
if err := f.ColNameErrs(columnNames); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
// Below code ensures the whereClause has no errors.
|
|
if whereClause != nil {
|
|
tempClause := whereClause
|
|
if err := whereClauseNameErrs(tempClause, alias, f); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for i := 0; i < len(myFuncs.funcExpr); i++ {
|
|
if myFuncs.funcExpr[i] == nil {
|
|
continue
|
|
}
|
|
if err := evaluateFuncErr(myFuncs.funcExpr[i], f); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|