mirror of https://github.com/minio/minio.git
299 lines
9.8 KiB
Go
299 lines
9.8 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
// Tests validate bucket name.
|
|
func TestIsValidBucketName(t *testing.T) {
|
|
testCases := []struct {
|
|
bucketName string
|
|
shouldPass bool
|
|
}{
|
|
// cases which should pass the test.
|
|
// passing in valid bucket names.
|
|
{"lol", true},
|
|
{"1-this-is-valid", true},
|
|
{"1-this-too-is-valid-1", true},
|
|
{"this.works.too.1", true},
|
|
{"1234567", true},
|
|
{"123", true},
|
|
{"s3-eu-west-1.amazonaws.com", true},
|
|
{"ideas-are-more-powerful-than-guns", true},
|
|
{"testbucket", true},
|
|
{"1bucket", true},
|
|
{"bucket1", true},
|
|
{"a.b", true},
|
|
{"ab.a.bc", true},
|
|
// cases for which test should fail.
|
|
// passing invalid bucket names.
|
|
{"------", false},
|
|
{"my..bucket", false},
|
|
{"192.168.1.1", false},
|
|
{"$this-is-not-valid-too", false},
|
|
{"contains-$-dollar", false},
|
|
{"contains-^-carret", false},
|
|
{"contains-$-dollar", false},
|
|
{"contains-$-dollar", false},
|
|
{"......", false},
|
|
{"", false},
|
|
{"a", false},
|
|
{"ab", false},
|
|
{".starts-with-a-dot", false},
|
|
{"ends-with-a-dot.", false},
|
|
{"ends-with-a-dash-", false},
|
|
{"-starts-with-a-dash", false},
|
|
{"THIS-BEGINS-WITH-UPPERCASe", false},
|
|
{"tHIS-ENDS-WITH-UPPERCASE", false},
|
|
{"ThisBeginsAndEndsWithUpperCasE", false},
|
|
{"una ñina", false},
|
|
{"dash-.may-not-appear-next-to-dot", false},
|
|
{"dash.-may-not-appear-next-to-dot", false},
|
|
{"dash-.-may-not-appear-next-to-dot", false},
|
|
{"lalalallalallalalalallalallalala-thestring-size-is-greater-than-63", false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
isValidBucketName := IsValidBucketName(testCase.bucketName)
|
|
if testCase.shouldPass && !isValidBucketName {
|
|
t.Errorf("Test case %d: Expected \"%s\" to be a valid bucket name", i+1, testCase.bucketName)
|
|
}
|
|
if !testCase.shouldPass && isValidBucketName {
|
|
t.Errorf("Test case %d: Expected bucket name \"%s\" to be invalid", i+1, testCase.bucketName)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests for validate object name.
|
|
func TestIsValidObjectName(t *testing.T) {
|
|
testCases := []struct {
|
|
objectName string
|
|
shouldPass bool
|
|
}{
|
|
// cases which should pass the test.
|
|
// passing in valid object name.
|
|
{"object", true},
|
|
{"The Shining Script <v1>.pdf", true},
|
|
{"Cost Benefit Analysis (2009-2010).pptx", true},
|
|
{"117Gn8rfHL2ACARPAhaFd0AGzic9pUbIA/5OCn5A", true},
|
|
{"SHØRT", true},
|
|
{"f*le", true},
|
|
{"contains-^-carret", true},
|
|
{"contains-|-pipe", true},
|
|
{"contains-\"-quote", true},
|
|
{"contains-`-tick", true},
|
|
{"..test", true},
|
|
{".. test", true},
|
|
{". test", true},
|
|
{".test", true},
|
|
{"There are far too many object names, and far too few bucket names!", true},
|
|
// cases for which test should fail.
|
|
// passing invalid object names.
|
|
{"", false},
|
|
{"a/b/c/", false},
|
|
{"/a/b/c", false},
|
|
{"../../etc", false},
|
|
{"../../", false},
|
|
{"/../../etc", false},
|
|
{" ../etc", false},
|
|
{"./././", false},
|
|
{"./etc", false},
|
|
{"contains-\\-backslash", false},
|
|
{string([]byte{0xff, 0xfe, 0xfd}), false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
isValidObjectName := IsValidObjectName(testCase.objectName)
|
|
if testCase.shouldPass && !isValidObjectName {
|
|
t.Errorf("Test case %d: Expected \"%s\" to be a valid object name", i+1, testCase.objectName)
|
|
}
|
|
if !testCase.shouldPass && isValidObjectName {
|
|
t.Errorf("Test case %d: Expected object name \"%s\" to be invalid", i+1, testCase.objectName)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests getCompleteMultipartMD5
|
|
func TestGetCompleteMultipartMD5(t *testing.T) {
|
|
testCases := []struct {
|
|
parts []CompletePart
|
|
expectedResult string
|
|
expectedErr string
|
|
}{
|
|
// Wrong MD5 hash string
|
|
{[]CompletePart{{ETag: "wrong-md5-hash-string"}}, "", "encoding/hex: invalid byte: U+0077 'w'"},
|
|
|
|
// Single CompletePart with valid MD5 hash string.
|
|
{[]CompletePart{{ETag: "cf1f738a5924e645913c984e0fe3d708"}}, "10dc1617fbcf0bd0858048cb96e6bd77-1", ""},
|
|
|
|
// Multiple CompletePart with valid MD5 hash string.
|
|
{[]CompletePart{{ETag: "cf1f738a5924e645913c984e0fe3d708"}, {ETag: "9ccbc9a80eee7fb6fdd22441db2aedbd"}}, "0239a86b5266bb624f0ac60ba2aed6c8-2", ""},
|
|
}
|
|
|
|
for i, test := range testCases {
|
|
result, err := getCompleteMultipartMD5(context.Background(), test.parts)
|
|
if result != test.expectedResult {
|
|
t.Fatalf("test %d failed: expected: result=%v, got=%v", i+1, test.expectedResult, result)
|
|
}
|
|
errString := ""
|
|
if err != nil {
|
|
errString = err.Error()
|
|
}
|
|
if errString != test.expectedErr {
|
|
t.Fatalf("test %d failed: expected: err=%v, got=%v", i+1, test.expectedErr, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestIsMinioBucketName - Tests isMinioBucketName helper function.
|
|
func TestIsMinioMetaBucketName(t *testing.T) {
|
|
testCases := []struct {
|
|
bucket string
|
|
result bool
|
|
}{
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaBucket,
|
|
result: true,
|
|
},
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaMultipartBucket,
|
|
result: true,
|
|
},
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaTmpBucket,
|
|
result: true,
|
|
},
|
|
// Normal bucket
|
|
{
|
|
bucket: "mybucket",
|
|
result: false,
|
|
},
|
|
}
|
|
|
|
for i, test := range testCases {
|
|
actual := isMinioMetaBucketName(test.bucket)
|
|
if actual != test.result {
|
|
t.Errorf("Test %d - expected %v but received %v",
|
|
i+1, test.result, actual)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests RemoveStandardStorageClass method. Expectation is metadata map
|
|
// should be cleared of x-amz-storage-class, if it is set to STANDARD
|
|
func TestRemoveStandardStorageClass(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := removeStandardStorageClass(tt.metadata); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests CleanMetadata method. Expectation is metadata map
|
|
// should be cleared of etag, md5Sum and x-amz-storage-class, if it is set to STANDARD
|
|
func TestCleanMetadata(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "md5Sum": "abcde"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := cleanMetadata(tt.metadata); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests CleanMetadataKeys method. Expectation is metadata map
|
|
// should be cleared of keys passed to CleanMetadataKeys method
|
|
func TestCleanMetadataKeys(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
keys []string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD", "md5": "abcde"},
|
|
keys: []string{"etag", "md5"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "STANDARD"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY", "md5sum": "abcde"},
|
|
keys: []string{"etag", "md5sum"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "xyz": "abcde"},
|
|
keys: []string{"etag", "xyz"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := cleanMetadataKeys(tt.metadata, tt.keys...); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|