mirror of
https://github.com/minio/minio.git
synced 2025-10-30 00:05:02 -04:00
fix(api): Don't send responses twice. In some cases multiple responses are being sent for one request, causing the API server to incorrectly drop connections. This change introduces a ResponseWriter which tracks whether a response has already been sent. This is used to prevent a response being sent if something already has (e.g. by a preconditions check function). Fixes #21633. Co-authored-by: Menno Finlay-Smits <hello@menno.io>
215 lines
5.8 KiB
Go
215 lines
5.8 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/klauspost/compress/gzhttp"
|
|
)
|
|
|
|
// Tests object location.
|
|
func TestObjectLocation(t *testing.T) {
|
|
testCases := []struct {
|
|
request *http.Request
|
|
bucket, object string
|
|
domains []string
|
|
expectedLocation string
|
|
}{
|
|
// Server binding to localhost IP with https.
|
|
{
|
|
request: &http.Request{
|
|
Host: "127.0.0.1:9000",
|
|
Header: map[string][]string{
|
|
"X-Forwarded-Scheme": {httpScheme},
|
|
},
|
|
},
|
|
bucket: "testbucket1",
|
|
object: "test/1.txt",
|
|
expectedLocation: "http://127.0.0.1:9000/testbucket1/test/1.txt",
|
|
},
|
|
{
|
|
request: &http.Request{
|
|
Host: "127.0.0.1:9000",
|
|
Header: map[string][]string{
|
|
"X-Forwarded-Scheme": {httpsScheme},
|
|
},
|
|
},
|
|
bucket: "testbucket1",
|
|
object: "test/1.txt",
|
|
expectedLocation: "https://127.0.0.1:9000/testbucket1/test/1.txt",
|
|
},
|
|
// Server binding to fqdn.
|
|
{
|
|
request: &http.Request{
|
|
Host: "s3.mybucket.org",
|
|
Header: map[string][]string{
|
|
"X-Forwarded-Scheme": {httpScheme},
|
|
},
|
|
},
|
|
bucket: "mybucket",
|
|
object: "test/1.txt",
|
|
expectedLocation: "http://s3.mybucket.org/mybucket/test/1.txt",
|
|
},
|
|
// Server binding to fqdn.
|
|
{
|
|
request: &http.Request{
|
|
Host: "mys3.mybucket.org",
|
|
Header: map[string][]string{},
|
|
},
|
|
bucket: "mybucket",
|
|
object: "test/1.txt",
|
|
expectedLocation: "http://mys3.mybucket.org/mybucket/test/1.txt",
|
|
},
|
|
// Server with virtual domain name.
|
|
{
|
|
request: &http.Request{
|
|
Host: "mybucket.mys3.bucket.org",
|
|
Header: map[string][]string{},
|
|
},
|
|
domains: []string{"mys3.bucket.org"},
|
|
bucket: "mybucket",
|
|
object: "test/1.txt",
|
|
expectedLocation: "http://mybucket.mys3.bucket.org/test/1.txt",
|
|
},
|
|
{
|
|
request: &http.Request{
|
|
Host: "mybucket.mys3.bucket.org",
|
|
Header: map[string][]string{
|
|
"X-Forwarded-Scheme": {httpsScheme},
|
|
},
|
|
},
|
|
domains: []string{"mys3.bucket.org"},
|
|
bucket: "mybucket",
|
|
object: "test/1.txt",
|
|
expectedLocation: "https://mybucket.mys3.bucket.org/test/1.txt",
|
|
},
|
|
}
|
|
for _, testCase := range testCases {
|
|
t.Run("", func(t *testing.T) {
|
|
gotLocation := getObjectLocation(testCase.request, testCase.domains, testCase.bucket, testCase.object)
|
|
if testCase.expectedLocation != gotLocation {
|
|
t.Errorf("expected %s, got %s", testCase.expectedLocation, gotLocation)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// Tests getURLScheme function behavior.
|
|
func TestGetURLScheme(t *testing.T) {
|
|
tls := false
|
|
gotScheme := getURLScheme(tls)
|
|
if gotScheme != httpScheme {
|
|
t.Errorf("Expected %s, got %s", httpScheme, gotScheme)
|
|
}
|
|
tls = true
|
|
gotScheme = getURLScheme(tls)
|
|
if gotScheme != httpsScheme {
|
|
t.Errorf("Expected %s, got %s", httpsScheme, gotScheme)
|
|
}
|
|
}
|
|
|
|
func TestTrackingResponseWriter(t *testing.T) {
|
|
rw := httptest.NewRecorder()
|
|
trw := &trackingResponseWriter{ResponseWriter: rw}
|
|
trw.WriteHeader(123)
|
|
if !trw.headerWritten {
|
|
t.Fatal("headerWritten was not set by WriteHeader call")
|
|
}
|
|
|
|
_, err := trw.Write([]byte("hello"))
|
|
if err != nil {
|
|
t.Fatalf("Write unexpectedly failed: %v", err)
|
|
}
|
|
|
|
// Check that WriteHeader and Write were called on the underlying response writer
|
|
resp := rw.Result()
|
|
if resp.StatusCode != 123 {
|
|
t.Fatalf("unexpected status: %v", resp.StatusCode)
|
|
}
|
|
body, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
t.Fatalf("reading response body failed: %v", err)
|
|
}
|
|
if string(body) != "hello" {
|
|
t.Fatalf("response body incorrect: %v", string(body))
|
|
}
|
|
|
|
// Check that Unwrap works
|
|
if trw.Unwrap() != rw {
|
|
t.Fatalf("Unwrap returned wrong result: %v", trw.Unwrap())
|
|
}
|
|
}
|
|
|
|
func TestHeadersAlreadyWritten(t *testing.T) {
|
|
rw := httptest.NewRecorder()
|
|
trw := &trackingResponseWriter{ResponseWriter: rw}
|
|
|
|
if headersAlreadyWritten(trw) {
|
|
t.Fatal("headers have not been written yet")
|
|
}
|
|
|
|
trw.WriteHeader(123)
|
|
if !headersAlreadyWritten(trw) {
|
|
t.Fatal("headers were written")
|
|
}
|
|
}
|
|
|
|
func TestHeadersAlreadyWrittenWrapped(t *testing.T) {
|
|
rw := httptest.NewRecorder()
|
|
trw := &trackingResponseWriter{ResponseWriter: rw}
|
|
wrap1 := &gzhttp.NoGzipResponseWriter{ResponseWriter: trw}
|
|
wrap2 := &gzhttp.NoGzipResponseWriter{ResponseWriter: wrap1}
|
|
|
|
if headersAlreadyWritten(wrap2) {
|
|
t.Fatal("headers have not been written yet")
|
|
}
|
|
|
|
wrap2.WriteHeader(123)
|
|
if !headersAlreadyWritten(wrap2) {
|
|
t.Fatal("headers were written")
|
|
}
|
|
}
|
|
|
|
func TestWriteResponseHeadersNotWritten(t *testing.T) {
|
|
rw := httptest.NewRecorder()
|
|
trw := &trackingResponseWriter{ResponseWriter: rw}
|
|
|
|
writeResponse(trw, 299, []byte("hello"), "application/foo")
|
|
|
|
resp := rw.Result()
|
|
if resp.StatusCode != 299 {
|
|
t.Fatal("response wasn't written")
|
|
}
|
|
}
|
|
|
|
func TestWriteResponseHeadersWritten(t *testing.T) {
|
|
rw := httptest.NewRecorder()
|
|
rw.Code = -1
|
|
trw := &trackingResponseWriter{ResponseWriter: rw, headerWritten: true}
|
|
|
|
writeResponse(trw, 200, []byte("hello"), "application/foo")
|
|
|
|
if rw.Code != -1 {
|
|
t.Fatalf("response was written when it shouldn't have been (Code=%v)", rw.Code)
|
|
}
|
|
}
|