mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
2f9e2147f5
PUT calls cannot afford to have large latency build-ups due to contentious usage.json, or worse letting them fail with some unexpected error, this can happen when this file is concurrently being updated via scanner or it is being healed during a disk replacement heal. However, these are fairly quick in theory, stressed clusters can quickly show visible latency this can add up leading to invalid errors returned during PUT. It is perhaps okay for us to relax this error return requirement instead, make sure that we log that we are proceeding to take in the requests while the quota is using an older value for the quota enforcement. These things will reconcile themselves eventually, via scanner making sure to overwrite the usage.json. Bonus: make sure that storage-rest-client sets ExpectTimeouts to be 'true', such that DiskInfo() call with contextTimeout does not prematurely disconnect the servers leading to a longer healthCheck, back-off routine. This can easily pile up while also causing active callers to disconnect, leading to quorum loss. DiskInfo is actively used in the PUT, Multipart call path for upgrading parity when disks are down, it in-turn shouldn't cause more disks to go down.
134 lines
4.1 KiB
Go
134 lines
4.1 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/minio/madmin-go/v2"
|
|
"github.com/minio/minio/internal/logger"
|
|
)
|
|
|
|
// BucketQuotaSys - map of bucket and quota configuration.
|
|
type BucketQuotaSys struct {
|
|
bucketStorageCache timedValue
|
|
}
|
|
|
|
// Get - Get quota configuration.
|
|
func (sys *BucketQuotaSys) Get(ctx context.Context, bucketName string) (*madmin.BucketQuota, error) {
|
|
qCfg, _, err := globalBucketMetadataSys.GetQuotaConfig(ctx, bucketName)
|
|
return qCfg, err
|
|
}
|
|
|
|
// NewBucketQuotaSys returns initialized BucketQuotaSys
|
|
func NewBucketQuotaSys() *BucketQuotaSys {
|
|
return &BucketQuotaSys{}
|
|
}
|
|
|
|
// Init initialize bucket quota.
|
|
func (sys *BucketQuotaSys) Init(objAPI ObjectLayer) {
|
|
sys.bucketStorageCache.Once.Do(func() {
|
|
// Set this to 10 secs since its enough, as scanner
|
|
// does not update the bucket usage values frequently.
|
|
sys.bucketStorageCache.TTL = 10 * time.Second
|
|
// Rely on older value if usage loading fails from disk.
|
|
sys.bucketStorageCache.Relax = true
|
|
sys.bucketStorageCache.Update = func() (interface{}, error) {
|
|
ctx, done := context.WithTimeout(context.Background(), 1*time.Second)
|
|
defer done()
|
|
|
|
return loadDataUsageFromBackend(ctx, objAPI)
|
|
}
|
|
})
|
|
}
|
|
|
|
// GetBucketUsageInfo return bucket usage info for a given bucket
|
|
func (sys *BucketQuotaSys) GetBucketUsageInfo(bucket string) (BucketUsageInfo, error) {
|
|
v, err := sys.bucketStorageCache.Get()
|
|
if err != nil && v != nil {
|
|
logger.LogIf(GlobalContext, fmt.Errorf("unable to retrieve usage information for bucket: %s, relying on older value cached in-memory: err(%v)", bucket, err))
|
|
}
|
|
if v == nil {
|
|
logger.LogIf(GlobalContext, errors.New("unable to retrieve usage information for bucket: %s, no reliable usage value available - quota will not be enforced"))
|
|
}
|
|
|
|
var bui BucketUsageInfo
|
|
|
|
dui, ok := v.(DataUsageInfo)
|
|
if ok {
|
|
bui = dui.BucketsUsage[bucket]
|
|
}
|
|
|
|
return bui, nil
|
|
}
|
|
|
|
// parseBucketQuota parses BucketQuota from json
|
|
func parseBucketQuota(bucket string, data []byte) (quotaCfg *madmin.BucketQuota, err error) {
|
|
quotaCfg = &madmin.BucketQuota{}
|
|
if err = json.Unmarshal(data, quotaCfg); err != nil {
|
|
return quotaCfg, err
|
|
}
|
|
if !quotaCfg.IsValid() {
|
|
if quotaCfg.Type == "fifo" {
|
|
logger.LogIf(GlobalContext, errors.New("Detected older 'fifo' quota config, 'fifo' feature is removed and not supported anymore. Please clear your quota configs using 'mc admin bucket quota alias/bucket --clear' and use 'mc ilm add' for expiration of objects"))
|
|
return quotaCfg, fmt.Errorf("invalid quota type 'fifo'")
|
|
}
|
|
return quotaCfg, fmt.Errorf("Invalid quota config %#v", quotaCfg)
|
|
}
|
|
return
|
|
}
|
|
|
|
func (sys *BucketQuotaSys) enforceQuotaHard(ctx context.Context, bucket string, size int64) error {
|
|
if size < 0 {
|
|
return nil
|
|
}
|
|
|
|
q, err := sys.Get(ctx, bucket)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if q != nil && q.Type == madmin.HardQuota && q.Quota > 0 {
|
|
if uint64(size) >= q.Quota { // check if file size already exceeds the quota
|
|
return BucketQuotaExceeded{Bucket: bucket}
|
|
}
|
|
|
|
bui, err := sys.GetBucketUsageInfo(bucket)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if bui.Size > 0 && ((bui.Size + uint64(size)) >= q.Quota) {
|
|
return BucketQuotaExceeded{Bucket: bucket}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func enforceBucketQuotaHard(ctx context.Context, bucket string, size int64) error {
|
|
if globalBucketQuotaSys == nil {
|
|
return nil
|
|
}
|
|
return globalBucketQuotaSys.enforceQuotaHard(ctx, bucket, size)
|
|
}
|