minio

mirror of https://github.com/minio/minio.git synced 2025-03-22 05:24:15 -04:00

History

Fix CreateFile shared buffer corruption. (#18652 )

`(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`.

The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`, 
which reads into an `ODirectPool` buffer.

`(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading, 
the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused.

However, if the async `Read` call unblocks, it will write to the now recycled buffer.

Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts. 
This is not a disk timeout, anyway.

Regression in https://github.com/minio/minio/pull/17745

2023-12-14 10:51:57 -08:00

append-file_nix.go

run gofumpt cleanup across code-base (#14015 )

2022-01-02 09:15:06 -08:00

append-file_windows.go

run gofumpt cleanup across code-base (#14015 )

2022-01-02 09:15:06 -08:00

discard.go

replace io.Discard usage to fix some NUMA copy() latencies (#18394 )

2023-11-06 14:26:08 -08:00

hardlimitreader.go

Signed trailers for signature v4 (#16484 )