mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
d350b666ff
The bottom line is delete markers are a nuisance, most applications are not version aware and this has simply complicated the version management. AWS S3 gave an unnecessary complication overhead for customers, they need to now manage these markers by applying ILM settings and clean them up on a regular basis. To make matters worse all these delete markers get replicated as well in a replicated setup, requiring two ILM settings on each site. This PR is an attempt to address this inferior implementation by deviating MinIO towards an idempotent delete marker implementation i.e MinIO will never create any more than single consecutive delete markers. This significantly reduces operational overhead by making versioning more useful for real data. This is an S3 spec deviation for pragmatic reasons.
52 lines
1.4 KiB
YAML
52 lines
1.4 KiB
YAML
name: FIPS Build Test
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
|
|
# This ensures that previous jobs for the PR are canceled when the PR is
|
|
# updated.
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.head_ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
build:
|
|
name: Go BoringCrypto ${{ matrix.go-version }} on ${{ matrix.os }}
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
matrix:
|
|
go-version: [1.18.5b7]
|
|
os: [ubuntu-latest]
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v2
|
|
|
|
- name: Setup dockerfile for build test
|
|
run: |
|
|
echo "FROM us-docker.pkg.dev/google.com/api-project-999119582588/go-boringcrypto/golang:${{ matrix.go-version }}" > Dockerfile.fips.test
|
|
echo "COPY . /minio" >> Dockerfile.fips.test
|
|
echo "WORKDIR /minio" >> Dockerfile.fips.test
|
|
echo "RUN make" >> Dockerfile.fips.test
|
|
|
|
- name: Build
|
|
uses: docker/build-push-action@v3
|
|
with:
|
|
context: .
|
|
file: Dockerfile.fips.test
|
|
push: false
|
|
load: true
|
|
tags: minio/fips-test:latest
|
|
|
|
# This should fail if grep returns non-zero exit
|
|
- name: Test binary
|
|
run: |
|
|
docker run --rm minio/fips-test:latest ./minio --version
|
|
docker run --rm -i minio/fips-test:latest /bin/bash -c 'go tool nm ./minio' | grep -q FIPS
|