mirror of
https://github.com/minio/minio.git
synced 2024-12-26 23:25:54 -05:00
d2f42d830f
In distributed mode, use REST API to acquire and manage locks instead of RPC. RPC has been completely removed from MinIO source. Since we are moving from RPC to REST, we cannot use rolling upgrades as the nodes that have not yet been upgraded cannot talk to the ones that have been upgraded. We expect all minio processes on all nodes to be stopped and then the upgrade process to be completed. Also force http1.1 for inter-node communication
204 lines
5.7 KiB
Go
204 lines
5.7 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2019 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"os"
|
|
"reflect"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Helper function to create a lock server for testing
|
|
func createLockTestServer(t *testing.T) (string, *lockRESTServer, string) {
|
|
obj, fsDir, err := prepareFS()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
|
|
t.Fatalf("unable initialize config file, %s", err)
|
|
}
|
|
|
|
locker := &lockRESTServer{
|
|
ll: localLocker{
|
|
mutex: sync.Mutex{},
|
|
serviceEndpoint: "rpc-path",
|
|
lockMap: make(map[string][]lockRequesterInfo),
|
|
},
|
|
}
|
|
creds := globalServerConfig.GetCredential()
|
|
token, err := authenticateNode(creds.AccessKey, creds.SecretKey)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return fsDir, locker, token
|
|
}
|
|
|
|
// Test function to remove lock entries from map only in case they still exist based on name & uid combination
|
|
func TestLockRpcServerRemoveEntryIfExists(t *testing.T) {
|
|
testPath, locker, _ := createLockTestServer(t)
|
|
defer os.RemoveAll(testPath)
|
|
|
|
lri := lockRequesterInfo{
|
|
Writer: false,
|
|
Node: "host",
|
|
ServiceEndpoint: "rpc-path",
|
|
UID: "0123-4567",
|
|
Timestamp: UTCNow(),
|
|
TimeLastCheck: UTCNow(),
|
|
}
|
|
nlrip := nameLockRequesterInfoPair{name: "name", lri: lri}
|
|
|
|
// first test by simulating item has already been deleted
|
|
locker.ll.removeEntryIfExists(nlrip)
|
|
{
|
|
gotLri := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
|
|
// then test normal deletion
|
|
locker.ll.lockMap["name"] = []lockRequesterInfo{lri} // add item
|
|
locker.ll.removeEntryIfExists(nlrip)
|
|
{
|
|
gotLri := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Test function to remove lock entries from map based on name & uid combination
|
|
func TestLockRpcServerRemoveEntry(t *testing.T) {
|
|
testPath, locker, _ := createLockTestServer(t)
|
|
defer os.RemoveAll(testPath)
|
|
|
|
lockRequesterInfo1 := lockRequesterInfo{
|
|
Writer: true,
|
|
Node: "host",
|
|
ServiceEndpoint: "rpc-path",
|
|
UID: "0123-4567",
|
|
Timestamp: UTCNow(),
|
|
TimeLastCheck: UTCNow(),
|
|
}
|
|
lockRequesterInfo2 := lockRequesterInfo{
|
|
Writer: true,
|
|
Node: "host",
|
|
ServiceEndpoint: "rpc-path",
|
|
UID: "89ab-cdef",
|
|
Timestamp: UTCNow(),
|
|
TimeLastCheck: UTCNow(),
|
|
}
|
|
|
|
locker.ll.lockMap["name"] = []lockRequesterInfo{
|
|
lockRequesterInfo1,
|
|
lockRequesterInfo2,
|
|
}
|
|
|
|
lri := locker.ll.lockMap["name"]
|
|
|
|
// test unknown uid
|
|
if locker.ll.removeEntry("name", "unknown-uid", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", false, true)
|
|
}
|
|
|
|
if !locker.ll.removeEntry("name", "0123-4567", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", true, false)
|
|
} else {
|
|
gotLri := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo{lockRequesterInfo2}
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
|
|
if !locker.ll.removeEntry("name", "89ab-cdef", &lri) {
|
|
t.Errorf("Expected %#v, got %#v", true, false)
|
|
} else {
|
|
gotLri := locker.ll.lockMap["name"]
|
|
expectedLri := []lockRequesterInfo(nil)
|
|
if !reflect.DeepEqual(expectedLri, gotLri) {
|
|
t.Errorf("Expected %#v, got %#v", expectedLri, gotLri)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests function returning long lived locks.
|
|
func TestLockRpcServerGetLongLivedLocks(t *testing.T) {
|
|
ut := UTCNow()
|
|
// Collection of test cases for verifying returning valid long lived locks.
|
|
testCases := []struct {
|
|
lockMap map[string][]lockRequesterInfo
|
|
lockInterval time.Duration
|
|
expectedNSLR []nameLockRequesterInfoPair
|
|
}{
|
|
// Testcase - 1 validates long lived locks, returns empty list.
|
|
{
|
|
lockMap: map[string][]lockRequesterInfo{
|
|
"test": {{
|
|
Writer: true,
|
|
Node: "10.1.10.21",
|
|
ServiceEndpoint: "/lock/mnt/disk1",
|
|
UID: "10000112",
|
|
Timestamp: ut,
|
|
TimeLastCheck: ut,
|
|
}},
|
|
},
|
|
lockInterval: 1 * time.Minute,
|
|
expectedNSLR: []nameLockRequesterInfoPair{},
|
|
},
|
|
// Testcase - 2 validates long lived locks, returns at least one list.
|
|
{
|
|
lockMap: map[string][]lockRequesterInfo{
|
|
"test": {{
|
|
Writer: true,
|
|
Node: "10.1.10.21",
|
|
ServiceEndpoint: "/lock/mnt/disk1",
|
|
UID: "10000112",
|
|
Timestamp: ut,
|
|
TimeLastCheck: ut.Add(-2 * time.Minute),
|
|
}},
|
|
},
|
|
lockInterval: 1 * time.Minute,
|
|
expectedNSLR: []nameLockRequesterInfoPair{
|
|
{
|
|
name: "test",
|
|
lri: lockRequesterInfo{
|
|
Writer: true,
|
|
Node: "10.1.10.21",
|
|
ServiceEndpoint: "/lock/mnt/disk1",
|
|
UID: "10000112",
|
|
Timestamp: ut,
|
|
TimeLastCheck: ut.Add(-2 * time.Minute),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// Validates all test cases here.
|
|
for i, testCase := range testCases {
|
|
nsLR := getLongLivedLocks(testCase.lockMap, testCase.lockInterval)
|
|
if !reflect.DeepEqual(testCase.expectedNSLR, nsLR) {
|
|
t.Errorf("Test %d: Expected %#v, got %#v", i+1, testCase.expectedNSLR, nsLR)
|
|
}
|
|
}
|
|
}
|