mirror of
https://github.com/minio/minio.git
synced 2024-12-25 14:45:54 -05:00
0b4bbe6d9e
object layer. Adding isBucketExist check for GetObjectInfo in the XL layer.
162 lines
6.3 KiB
Go
162 lines
6.3 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/md5"
|
|
"encoding/hex"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"strconv"
|
|
"testing"
|
|
)
|
|
|
|
// Wrapper for calling GetObjectInfo tests for both XL muliple disks and single node setup.
|
|
func TestGetObjectInfo(t *testing.T) {
|
|
ExecObjectLayerTest(t, testGetObjectInfo)
|
|
}
|
|
|
|
// Testing GetObjectInfo().
|
|
func testGetObjectInfo(obj ObjectLayer, instanceType string, t *testing.T) {
|
|
// This bucket is used for testing getObjectInfo operations.
|
|
err := obj.MakeBucket("test-getobjectinfo")
|
|
if err != nil {
|
|
t.Fatalf("%s : %s", instanceType, err.Error())
|
|
}
|
|
_, err = obj.PutObject("test-getobjectinfo", "Asia/asiapics.jpg", int64(len("asiapics")), bytes.NewBufferString("asiapics"), nil)
|
|
if err != nil {
|
|
t.Fatalf("%s : %s", instanceType, err.Error())
|
|
}
|
|
resultCases := []ObjectInfo{
|
|
// ObjectInfo -1.
|
|
// ObjectName set to a existing object in the test case (Test case 14).
|
|
{Bucket: "test-getobjectinfo", Name: "Asia/asiapics.jpg", ContentType: "image/jpeg", IsDir: false},
|
|
}
|
|
testCases := []struct {
|
|
bucketName string
|
|
objectName string
|
|
|
|
// Expected output of GetObjectInfo.
|
|
result ObjectInfo
|
|
err error
|
|
// Flag indicating whether the test is expected to pass or not.
|
|
shouldPass bool
|
|
}{
|
|
// Test cases with invalid bucket names ( Test number 1-4 ).
|
|
{".test", "", ObjectInfo{}, BucketNameInvalid{Bucket: ".test"}, false},
|
|
{"Test", "", ObjectInfo{}, BucketNameInvalid{Bucket: "Test"}, false},
|
|
{"---", "", ObjectInfo{}, BucketNameInvalid{Bucket: "---"}, false},
|
|
{"ad", "", ObjectInfo{}, BucketNameInvalid{Bucket: "ad"}, false},
|
|
// Test cases with valid but non-existing bucket names (Test number 5-7).
|
|
{"abcdefgh", "abc", ObjectInfo{}, BucketNotFound{Bucket: "abcdefgh"}, false},
|
|
{"ijklmnop", "efg", ObjectInfo{}, BucketNotFound{Bucket: "ijklmnop"}, false},
|
|
// Test cases with valid but non-existing bucket names and invalid object name (Test number 8-9).
|
|
{"abcdefgh", "", ObjectInfo{}, ObjectNameInvalid{Bucket: "abcdefgh", Object: ""}, false},
|
|
{"ijklmnop", "", ObjectInfo{}, ObjectNameInvalid{Bucket: "ijklmnop", Object: ""}, false},
|
|
// Test cases with non-existing object name with existing bucket (Test number 10-12).
|
|
{"test-getobjectinfo", "Africa", ObjectInfo{}, ObjectNotFound{Bucket: "test-getobjectinfo", Object: "Africa"}, false},
|
|
{"test-getobjectinfo", "Antartica", ObjectInfo{}, ObjectNotFound{Bucket: "test-getobjectinfo", Object: "Antartica"}, false},
|
|
{"test-getobjectinfo", "Asia/myfile", ObjectInfo{}, ObjectNotFound{Bucket: "test-getobjectinfo", Object: "Asia/myfile"}, false},
|
|
// Test case with existing bucket but object name set to a directory (Test number 13).
|
|
{"test-getobjectinfo", "Asia", ObjectInfo{}, ObjectNotFound{Bucket: "test-getobjectinfo", Object: "Asia"}, false},
|
|
// Valid case with existing object (Test number 14).
|
|
{"test-getobjectinfo", "Asia/asiapics.jpg", resultCases[0], nil, true},
|
|
}
|
|
for i, testCase := range testCases {
|
|
result, err := obj.GetObjectInfo(testCase.bucketName, testCase.objectName)
|
|
if err != nil && testCase.shouldPass {
|
|
t.Errorf("Test %d: %s: Expected to pass, but failed with: <ERROR> %s", i+1, instanceType, err.Error())
|
|
}
|
|
if err == nil && !testCase.shouldPass {
|
|
t.Errorf("Test %d: %s: Expected to fail with <ERROR> \"%s\", but passed instead", i+1, instanceType, testCase.err.Error())
|
|
}
|
|
// Failed as expected, but does it fail for the expected reason.
|
|
if err != nil && !testCase.shouldPass {
|
|
if testCase.err.Error() != err.Error() {
|
|
t.Errorf("Test %d: %s: Expected to fail with error \"%s\", but instead failed with error \"%s\" instead", i+1, instanceType, testCase.err.Error(), err.Error())
|
|
}
|
|
}
|
|
|
|
// Test passes as expected, but the output values are verified for correctness here.
|
|
if err == nil && testCase.shouldPass {
|
|
if testCase.result.Bucket != result.Bucket {
|
|
t.Fatalf("Test %d: %s: Expected Bucket name to be '%s', but found '%s' instead", i+1, instanceType, testCase.result.Bucket, result.Bucket)
|
|
}
|
|
if testCase.result.Name != result.Name {
|
|
t.Errorf("Test %d: %s: Expected Object name to be %s, but instead found it to be %s", i+1, instanceType, testCase.result.Name, result.Name)
|
|
}
|
|
if testCase.result.ContentType != result.ContentType {
|
|
t.Errorf("Test %d: %s: Expected Content Type of the object to be %v, but instead found it to be %v", i+1, instanceType, testCase.result.ContentType, result.ContentType)
|
|
}
|
|
if testCase.result.IsDir != result.IsDir {
|
|
t.Errorf("Test %d: %s: Expected IsDir flag of the object to be %v, but instead found it to be %v", i+1, instanceType,testCase.result.IsDir, result.IsDir)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkGetObject(b *testing.B) {
|
|
// Make a temporary directory to use as the obj.
|
|
directory, err := ioutil.TempDir("", "minio-benchmark-getobject")
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(directory)
|
|
|
|
// Create the obj.
|
|
obj, err := newFSObjects(directory)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
|
|
// Make a bucket and put in a few objects.
|
|
err = obj.MakeBucket("bucket")
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
|
|
text := "Jack and Jill went up the hill / To fetch a pail of water."
|
|
hasher := md5.New()
|
|
hasher.Write([]byte(text))
|
|
metadata := make(map[string]string)
|
|
for i := 0; i < 10; i++ {
|
|
metadata["md5Sum"] = hex.EncodeToString(hasher.Sum(nil))
|
|
_, err = obj.PutObject("bucket", "object"+strconv.Itoa(i), int64(len(text)), bytes.NewBufferString(text), metadata)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
var buffer = new(bytes.Buffer)
|
|
r, err := obj.GetObject("bucket", "object"+strconv.Itoa(i%10), 0)
|
|
if err != nil {
|
|
b.Error(err)
|
|
}
|
|
if _, err := io.Copy(buffer, r); err != nil {
|
|
b.Error(err)
|
|
}
|
|
if buffer.Len() != len(text) {
|
|
b.Errorf("GetObject returned incorrect length %d (should be %d)\n", buffer.Len(), len(text))
|
|
}
|
|
r.Close()
|
|
}
|
|
}
|