mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
fe157166ca
Context timeout might race on each other when timeouts are lower i.e when two lock attempts happened very quickly on the same resource and the servers were yet trying to establish quorum. This situation can lead to locks held which wouldn't be unlocked and subsequent lock attempts would fail. This would require a complete server restart. A potential of this issue happening is when server is booting up and we are trying to hold a 'transaction.lock' in quick bursts of timeout.
58 lines
1.4 KiB
Go
58 lines
1.4 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2019 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/minio/minio/pkg/dsync"
|
|
)
|
|
|
|
// Tests lock rpc client.
|
|
func TestLockRESTlient(t *testing.T) {
|
|
endpoint, err := NewEndpoint("http://localhost:9000")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error %v", err)
|
|
}
|
|
lkClient := newlockRESTClient(endpoint)
|
|
if !lkClient.IsOnline() {
|
|
t.Fatalf("unexpected error. connection failed")
|
|
}
|
|
|
|
// Attempt all calls.
|
|
_, err = lkClient.RLock(context.Background(), dsync.LockArgs{})
|
|
if err == nil {
|
|
t.Fatal("Expected for Rlock to fail")
|
|
}
|
|
|
|
_, err = lkClient.Lock(context.Background(), dsync.LockArgs{})
|
|
if err == nil {
|
|
t.Fatal("Expected for Lock to fail")
|
|
}
|
|
|
|
_, err = lkClient.RUnlock(dsync.LockArgs{})
|
|
if err == nil {
|
|
t.Fatal("Expected for RUnlock to fail")
|
|
}
|
|
|
|
_, err = lkClient.Unlock(dsync.LockArgs{})
|
|
if err == nil {
|
|
t.Fatal("Expected for Unlock to fail")
|
|
}
|
|
}
|