mirror of
https://github.com/minio/minio.git
synced 2024-12-26 23:25:54 -05:00
61175ef091
- over the course of a project history every maintainer needs to update
its dependency packages, the problem essentially with godep is manipulating
GOPATH - this manipulation leads to static objects created at different locations
which end up conflicting with the overall functionality of golang.
This also leads to broken builds. There is no easier way out of this other than
asking developers to do 'godep restore' all the time. Which perhaps as a practice
doesn't sound like a clean solution. On the other hand 'godep restore' has its own
set of problems.
- govendor is a right tool but a stop gap tool until we wait for golangs official
1.5 version which fixes this vendoring issue once and for all.
- govendor provides consistency in terms of how import paths should be handled unlike
manipulation GOPATH.
This has advantages
- no more compiled objects being referenced in GOPATH and build time GOPATH
manging which leads to conflicts.
- proper import paths referencing the exact package a project is dependent on.
govendor is simple and provides the minimal necessary tooling to achieve this.
For now this is the right solution.
59 lines
1.4 KiB
Makefile
59 lines
1.4 KiB
Makefile
all: getdeps install
|
|
|
|
checkdeps:
|
|
@echo "Checking deps:"
|
|
@(env bash $(PWD)/buildscripts/checkdeps.sh)
|
|
|
|
checkgopath:
|
|
@echo "Checking if project is at ${GOPATH}"
|
|
@for mcpath in $(echo ${GOPATH} | sed 's/:/\n/g'); do if [ ! -d ${mcpath}/src/github.com/minio/minio ]; then echo "Project not found in ${mcpath}, please follow instructions provided at https://github.com/minio/minio/blob/master/CONTRIBUTING.md#setup-your-minio-github-repository" && exit 1; fi done
|
|
|
|
getdeps: checkdeps checkgopath
|
|
@go get github.com/golang/lint/golint && echo "Installed golint:"
|
|
@go get golang.org/x/tools/cmd/vet && echo "Installed vet:"
|
|
@go get github.com/fzipp/gocyclo && echo "Installed gocyclo:"
|
|
|
|
verifiers: getdeps vet fmt lint cyclo
|
|
|
|
vet:
|
|
@echo "Running $@:"
|
|
@go vet .
|
|
@go vet github.com/minio/minio/pkg...
|
|
fmt:
|
|
@echo "Running $@:"
|
|
@gofmt -s -l *.go
|
|
@gofmt -s -l pkg
|
|
|
|
lint:
|
|
@echo "Running $@:"
|
|
@golint .
|
|
@golint pkg
|
|
|
|
cyclo:
|
|
@echo "Running $@:"
|
|
@gocyclo -over 25 .
|
|
|
|
build: getdeps verifiers
|
|
@echo "Installing minio:"
|
|
@go generate ./...
|
|
@go test -race github.com/minio/minio/pkg...
|
|
|
|
gomake-all: build
|
|
@go install github.com/minio/minio
|
|
|
|
release: genversion
|
|
@echo "Installing minio for new version.go:"
|
|
@go install github.com/minio/minio
|
|
|
|
genversion:
|
|
@echo "Generating new minio version.go"
|
|
@go run genversion.go
|
|
|
|
install: gomake-all
|
|
|
|
clean:
|
|
@echo "Cleaning up all the generated files:"
|
|
@rm -fv cover.out
|
|
@rm -fv pkg/utils/split/TESTPREFIX.*
|
|
@rm -fv minio
|