mirror of
https://github.com/minio/minio.git
synced 2024-12-26 23:25:54 -05:00
7926401cbd
i.e., this rule element doesn't apply to DEL markers.
This is a breaking change to how ExpiredObejctDeleteAllVersions
functions today. This is necessary to avoid the following highly probable
footgun scenario in the future.
Scenario:
The user uses tags-based filtering to select an object's time to live(TTL).
The application sometimes deletes objects, too, making its latest
version a DEL marker. The previous implementation skipped tag-based filters
if the newest version was DEL marker, voiding the tag-based TTL. The user is
surprised to find objects that have expired sooner than expected.
* Add DelMarkerExpiration action
This ILM action removes all versions of an object if its
the latest version is a DEL marker.
```xml
<DelMarkerObjectExpiration>
<Days> 10 </Days>
</DelMarkerObjectExpiration>
```
1. Applies only to objects whose,
• The latest version is a DEL marker.
• satisfies the number of days criteria
2. Deletes all versions of this object
3. Associated rule can't have tag-based filtering
Includes,
- New bucket event type for deletion due to DelMarkerExpiration
64 lines
1.6 KiB
Go
64 lines
1.6 KiB
Go
// Copyright (c) 2024 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package lifecycle
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func TestDelMarkerExpParseAndValidate(t *testing.T) {
|
|
tests := []struct {
|
|
xml string
|
|
err error
|
|
}{
|
|
{
|
|
xml: `<DelMarkerExpiration> <Days> 1 </Days> </DelMarkerExpiration>`,
|
|
err: nil,
|
|
},
|
|
{
|
|
xml: `<DelMarkerExpiration> <Days> -1 </Days> </DelMarkerExpiration>`,
|
|
err: errInvalidDaysDelMarkerExpiration,
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
t.Run(fmt.Sprintf("TestDelMarker-%d", i), func(t *testing.T) {
|
|
var dexp DelMarkerExpiration
|
|
var fail bool
|
|
err := xml.Unmarshal([]byte(test.xml), &dexp)
|
|
if test.err == nil {
|
|
if err != nil {
|
|
fail = true
|
|
}
|
|
} else {
|
|
if err == nil {
|
|
fail = true
|
|
}
|
|
if test.err.Error() != err.Error() {
|
|
fail = true
|
|
}
|
|
}
|
|
if fail {
|
|
t.Fatalf("Expected %v but got %v", test.err, err)
|
|
}
|
|
})
|
|
}
|
|
}
|