// Copyright (c) 2015-2021 MinIO, Inc. // // This file is part of MinIO Object Storage stack // // This program is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // This program is distributed in the hope that it will be useful // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU Affero General Public License for more details. // // You should have received a copy of the GNU Affero General Public License // along with this program. If not, see . package cmd import ( "net/http" "net/http/httptest" "net/url" "strconv" "testing" "github.com/minio/minio/internal/crypto" "github.com/minio/minio/internal/grid" xhttp "github.com/minio/minio/internal/http" ) // Tests request guess function for net/rpc requests. func TestGuessIsRPC(t *testing.T) { if guessIsRPCReq(nil) { t.Fatal("Unexpected return for nil request") } u, err := url.Parse("http://localhost:9000/minio/lock") if err != nil { t.Fatal(err) } r := &http.Request{ Proto: "HTTP/1.0", Method: http.MethodPost, URL: u, } if !guessIsRPCReq(r) { t.Fatal("Test shouldn't fail for a possible net/rpc request.") } r = &http.Request{ Proto: "HTTP/1.1", Method: http.MethodGet, } if guessIsRPCReq(r) { t.Fatal("Test shouldn't report as net/rpc for a non net/rpc request.") } r = &http.Request{ Proto: "HTTP/1.1", Method: http.MethodGet, URL: &url.URL{Path: grid.RoutePath}, } if !guessIsRPCReq(r) { t.Fatal("Grid RPC path not detected") } } var isHTTPHeaderSizeTooLargeTests = []struct { header http.Header shouldFail bool }{ {header: generateHeader(0, 0), shouldFail: false}, {header: generateHeader(1024, 0), shouldFail: false}, {header: generateHeader(2048, 0), shouldFail: false}, {header: generateHeader(8*1024+1, 0), shouldFail: true}, {header: generateHeader(0, 1024), shouldFail: false}, {header: generateHeader(0, 2048), shouldFail: true}, {header: generateHeader(0, 2048+1), shouldFail: true}, } func generateHeader(size, usersize int) http.Header { header := http.Header{} for i := 0; i < size; i++ { header.Set(strconv.Itoa(i), "") } userlength := 0 for i := 0; userlength < usersize; i++ { userlength += len(userMetadataKeyPrefixes[0] + strconv.Itoa(i)) header.Set(userMetadataKeyPrefixes[0]+strconv.Itoa(i), "") } return header } func TestIsHTTPHeaderSizeTooLarge(t *testing.T) { for i, test := range isHTTPHeaderSizeTooLargeTests { if res := isHTTPHeaderSizeTooLarge(test.header); res != test.shouldFail { t.Errorf("Test %d: Expected %v got %v", i, res, test.shouldFail) } } } var containsReservedMetadataTests = []struct { header http.Header shouldFail bool }{ { header: http.Header{"X-Minio-Key": []string{"value"}}, }, { header: http.Header{crypto.MetaIV: []string{"iv"}}, shouldFail: true, }, { header: http.Header{crypto.MetaAlgorithm: []string{crypto.InsecureSealAlgorithm}}, shouldFail: true, }, { header: http.Header{crypto.MetaSealedKeySSEC: []string{"mac"}}, shouldFail: true, }, { header: http.Header{ReservedMetadataPrefix + "Key": []string{"value"}}, shouldFail: true, }, } func TestContainsReservedMetadata(t *testing.T) { for _, test := range containsReservedMetadataTests { test := test t.Run("", func(t *testing.T) { contains := containsReservedMetadata(test.header) if contains && !test.shouldFail { t.Errorf("contains reserved header but should not fail") } else if !contains && test.shouldFail { t.Errorf("does not contain reserved header but failed") } }) } } var sseTLSHandlerTests = []struct { URL *url.URL Header http.Header IsTLS, ShouldFail bool }{ {URL: &url.URL{}, Header: http.Header{}, IsTLS: false, ShouldFail: false}, // 0 {URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerAlgorithm: []string{"AES256"}}, IsTLS: false, ShouldFail: true}, // 1 {URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerAlgorithm: []string{"AES256"}}, IsTLS: true, ShouldFail: false}, // 2 {URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCustomerKey: []string{""}}, IsTLS: true, ShouldFail: false}, // 3 {URL: &url.URL{}, Header: http.Header{xhttp.AmzServerSideEncryptionCopyCustomerAlgorithm: []string{""}}, IsTLS: false, ShouldFail: true}, // 4 } func TestSSETLSHandler(t *testing.T) { defer func(isSSL bool) { globalIsTLS = isSSL }(globalIsTLS) // reset globalIsTLS after test var okHandler http.HandlerFunc = func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) } for i, test := range sseTLSHandlerTests { globalIsTLS = test.IsTLS w := httptest.NewRecorder() r := new(http.Request) r.Header = test.Header r.URL = test.URL h := setRequestValidityMiddleware(okHandler) h.ServeHTTP(w, r) switch { case test.ShouldFail && w.Code == http.StatusOK: t.Errorf("Test %d: should fail but status code is HTTP %d", i, w.Code) case !test.ShouldFail && w.Code != http.StatusOK: t.Errorf("Test %d: should not fail but status code is HTTP %d and not 200 OK", i, w.Code) } } }