// Copyright (c) 2015-2021 MinIO, Inc. // // This file is part of MinIO Object Storage stack // // This program is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // This program is distributed in the hope that it will be useful // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU Affero General Public License for more details. // // You should have received a copy of the GNU Affero General Public License // along with this program. If not, see . package cmd import ( "crypto/sha256" "encoding/hex" "encoding/json" "errors" "os" "reflect" "testing" ) // tests fixFormatErasureV3 - fix format.json on all disks. func TestFixFormatV3(t *testing.T) { erasureDirs, err := getRandomDisks(8) if err != nil { t.Fatal(err) } for _, erasureDir := range erasureDirs { defer os.RemoveAll(erasureDir) } endpoints := mustGetNewEndpoints(0, 8, erasureDirs...) storageDisks, errs := initStorageDisksWithErrors(endpoints, false) for _, err := range errs { if err != nil && err != errDiskNotFound { t.Fatal(err) } } format := newFormatErasureV3(1, 8) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 8) for j := 0; j < 8; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[0][j] formats[j] = newFormat } formats[1] = nil expThis := formats[2].Erasure.This formats[2].Erasure.This = "" if err := fixFormatErasureV3(storageDisks, endpoints, formats); err != nil { t.Fatal(err) } newFormats, errs := loadFormatErasureAll(storageDisks, false) for _, err := range errs { if err != nil && err != errUnformattedDisk { t.Fatal(err) } } gotThis := newFormats[2].Erasure.This if expThis != gotThis { t.Fatalf("expected uuid %s, got %s", expThis, gotThis) } } // tests formatErasureV3ThisEmpty conditions. func TestFormatErasureEmpty(t *testing.T) { format := newFormatErasureV3(1, 16) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 16) for j := 0; j < 16; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[0][j] formats[j] = newFormat } // empty format to indicate disk not found, but this // empty should return false. formats[0] = nil if ok := formatErasureV3ThisEmpty(formats); ok { t.Fatalf("expected value false, got %t", ok) } formats[2].Erasure.This = "" if ok := formatErasureV3ThisEmpty(formats); !ok { t.Fatalf("expected value true, got %t", ok) } } // Tests xl format migration. func TestFormatErasureMigrate(t *testing.T) { // Get test root. rootPath := t.TempDir() m := &formatErasureV1{} m.Format = formatBackendErasure m.Version = formatMetaVersionV1 m.Erasure.Version = formatErasureVersionV1 m.Erasure.Disk = mustGetUUID() m.Erasure.JBOD = []string{m.Erasure.Disk, mustGetUUID(), mustGetUUID(), mustGetUUID()} b, err := json.Marshal(m) if err != nil { t.Fatal(err) } if err = os.MkdirAll(pathJoin(rootPath, minioMetaBucket), os.FileMode(0o755)); err != nil { t.Fatal(err) } if err = os.WriteFile(pathJoin(rootPath, minioMetaBucket, formatConfigFile), b, os.FileMode(0o644)); err != nil { t.Fatal(err) } formatData, _, err := formatErasureMigrate(rootPath) if err != nil { t.Fatal(err) } migratedVersion, err := formatGetBackendErasureVersion(formatData) if err != nil { t.Fatal(err) } if migratedVersion != formatErasureVersionV3 { t.Fatalf("expected version: %s, got: %s", formatErasureVersionV3, migratedVersion) } b, err = os.ReadFile(pathJoin(rootPath, minioMetaBucket, formatConfigFile)) if err != nil { t.Fatal(err) } formatV3 := &formatErasureV3{} if err = json.Unmarshal(b, formatV3); err != nil { t.Fatal(err) } if formatV3.Erasure.This != m.Erasure.Disk { t.Fatalf("expected drive uuid: %s, got: %s", m.Erasure.Disk, formatV3.Erasure.This) } if len(formatV3.Erasure.Sets) != 1 { t.Fatalf("expected single set after migrating from v1 to v3, but found %d", len(formatV3.Erasure.Sets)) } if !reflect.DeepEqual(formatV3.Erasure.Sets[0], m.Erasure.JBOD) { t.Fatalf("expected drive uuid: %v, got: %v", m.Erasure.JBOD, formatV3.Erasure.Sets[0]) } m = &formatErasureV1{} m.Format = "unknown" m.Version = formatMetaVersionV1 m.Erasure.Version = formatErasureVersionV1 m.Erasure.Disk = mustGetUUID() m.Erasure.JBOD = []string{m.Erasure.Disk, mustGetUUID(), mustGetUUID(), mustGetUUID()} b, err = json.Marshal(m) if err != nil { t.Fatal(err) } if err = os.WriteFile(pathJoin(rootPath, minioMetaBucket, formatConfigFile), b, os.FileMode(0o644)); err != nil { t.Fatal(err) } if _, _, err = formatErasureMigrate(rootPath); err == nil { t.Fatal("Expected to fail with unexpected backend format") } m = &formatErasureV1{} m.Format = formatBackendErasure m.Version = formatMetaVersionV1 m.Erasure.Version = "30" m.Erasure.Disk = mustGetUUID() m.Erasure.JBOD = []string{m.Erasure.Disk, mustGetUUID(), mustGetUUID(), mustGetUUID()} b, err = json.Marshal(m) if err != nil { t.Fatal(err) } if err = os.WriteFile(pathJoin(rootPath, minioMetaBucket, formatConfigFile), b, os.FileMode(0o644)); err != nil { t.Fatal(err) } if _, _, err = formatErasureMigrate(rootPath); err == nil { t.Fatal("Expected to fail with unexpected backend format version number") } } // Tests check format xl value. func TestCheckFormatErasureValue(t *testing.T) { testCases := []struct { format *formatErasureV3 success bool }{ // Invalid Erasure format version "2". { &formatErasureV3{ formatMetaV1: formatMetaV1{ Version: "2", Format: "Erasure", }, Erasure: struct { Version string `json:"version"` This string `json:"this"` Sets [][]string `json:"sets"` DistributionAlgo string `json:"distributionAlgo"` }{ Version: "2", }, }, false, }, // Invalid Erasure format "Unknown". { &formatErasureV3{ formatMetaV1: formatMetaV1{ Version: "1", Format: "Unknown", }, Erasure: struct { Version string `json:"version"` This string `json:"this"` Sets [][]string `json:"sets"` DistributionAlgo string `json:"distributionAlgo"` }{ Version: "2", }, }, false, }, // Invalid Erasure format version "0". { &formatErasureV3{ formatMetaV1: formatMetaV1{ Version: "1", Format: "Erasure", }, Erasure: struct { Version string `json:"version"` This string `json:"this"` Sets [][]string `json:"sets"` DistributionAlgo string `json:"distributionAlgo"` }{ Version: "0", }, }, false, }, } // Valid all test cases. for i, testCase := range testCases { if err := checkFormatErasureValue(testCase.format, nil); err != nil && testCase.success { t.Errorf("Test %d: Expected failure %s", i+1, err) } } } // Tests getFormatErasureInQuorum() func TestGetFormatErasureInQuorumCheck(t *testing.T) { setCount := 2 setDriveCount := 16 format := newFormatErasureV3(setCount, setDriveCount) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 32) for i := 0; i < setCount; i++ { for j := 0; j < setDriveCount; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[i][j] formats[i*setDriveCount+j] = newFormat } } // Return a format from list of formats in quorum. quorumFormat, err := getFormatErasureInQuorum(formats) if err != nil { t.Fatal(err) } // Check if the reference format and input formats are same. if err = formatErasureV3Check(quorumFormat, formats[0]); err != nil { t.Fatal(err) } // QuorumFormat has .This field empty on purpose, expect a failure. if err = formatErasureV3Check(formats[0], quorumFormat); err == nil { t.Fatal("Unexpected success") } formats[0] = nil quorumFormat, err = getFormatErasureInQuorum(formats) if err != nil { t.Fatal(err) } badFormat := *quorumFormat badFormat.Erasure.Sets = nil if err = formatErasureV3Check(quorumFormat, &badFormat); err == nil { t.Fatal("Unexpected success") } badFormatUUID := *quorumFormat badFormatUUID.Erasure.Sets[0][0] = "bad-uuid" if err = formatErasureV3Check(quorumFormat, &badFormatUUID); err == nil { t.Fatal("Unexpected success") } badFormatSetSize := *quorumFormat badFormatSetSize.Erasure.Sets[0] = nil if err = formatErasureV3Check(quorumFormat, &badFormatSetSize); err == nil { t.Fatal("Unexpected success") } for i := range formats { if i < 17 { formats[i] = nil } } if _, err = getFormatErasureInQuorum(formats); err == nil { t.Fatal("Unexpected success") } } // Get backend Erasure format in quorum `format.json`. func getFormatErasureInQuorumOld(formats []*formatErasureV3) (*formatErasureV3, error) { formatHashes := make([]string, len(formats)) for i, format := range formats { if format == nil { continue } h := sha256.New() for _, set := range format.Erasure.Sets { for _, diskID := range set { h.Write([]byte(diskID)) } } formatHashes[i] = hex.EncodeToString(h.Sum(nil)) } formatCountMap := make(map[string]int) for _, hash := range formatHashes { if hash == "" { continue } formatCountMap[hash]++ } maxHash := "" maxCount := 0 for hash, count := range formatCountMap { if count > maxCount { maxCount = count maxHash = hash } } if maxCount < len(formats)/2 { return nil, errErasureReadQuorum } for i, hash := range formatHashes { if hash == maxHash { format := formats[i].Clone() format.Erasure.This = "" return format, nil } } return nil, errErasureReadQuorum } func BenchmarkGetFormatErasureInQuorumOld(b *testing.B) { setCount := 200 setDriveCount := 15 format := newFormatErasureV3(setCount, setDriveCount) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 15*200) for i := 0; i < setCount; i++ { for j := 0; j < setDriveCount; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[i][j] formats[i*setDriveCount+j] = newFormat } } b.ResetTimer() b.ReportAllocs() for i := 0; i < b.N; i++ { _, _ = getFormatErasureInQuorumOld(formats) } } func BenchmarkGetFormatErasureInQuorum(b *testing.B) { setCount := 200 setDriveCount := 15 format := newFormatErasureV3(setCount, setDriveCount) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 15*200) for i := 0; i < setCount; i++ { for j := 0; j < setDriveCount; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[i][j] formats[i*setDriveCount+j] = newFormat } } b.ResetTimer() b.ReportAllocs() for i := 0; i < b.N; i++ { _, _ = getFormatErasureInQuorum(formats) } } // Tests formatErasureGetDeploymentID() func TestGetErasureID(t *testing.T) { setCount := 2 setDriveCount := 8 format := newFormatErasureV3(setCount, setDriveCount) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 16) for i := 0; i < setCount; i++ { for j := 0; j < setDriveCount; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[i][j] formats[i*setDriveCount+j] = newFormat } } // Return a format from list of formats in quorum. quorumFormat, err := getFormatErasureInQuorum(formats) if err != nil { t.Fatal(err) } // Check if the reference format and input formats are same. var id string if id, err = formatErasureGetDeploymentID(quorumFormat, formats); err != nil { t.Fatal(err) } if id == "" { t.Fatal("ID cannot be empty.") } formats[0] = nil if id, err = formatErasureGetDeploymentID(quorumFormat, formats); err != nil { t.Fatal(err) } if id == "" { t.Fatal("ID cannot be empty.") } formats[1].Erasure.Sets[0][0] = "bad-uuid" if id, err = formatErasureGetDeploymentID(quorumFormat, formats); err != nil { t.Fatal(err) } if id == "" { t.Fatal("ID cannot be empty.") } formats[2].ID = "bad-id" if _, err = formatErasureGetDeploymentID(quorumFormat, formats); !errors.Is(err, errCorruptedFormat) { t.Fatalf("Unexpect error %s", err) } } // Initialize new format sets. func TestNewFormatSets(t *testing.T) { setCount := 2 setDriveCount := 16 format := newFormatErasureV3(setCount, setDriveCount) format.Erasure.DistributionAlgo = formatErasureVersionV2DistributionAlgoV1 formats := make([]*formatErasureV3, 32) errs := make([]error, 32) for i := 0; i < setCount; i++ { for j := 0; j < setDriveCount; j++ { newFormat := format.Clone() newFormat.Erasure.This = format.Erasure.Sets[i][j] formats[i*setDriveCount+j] = newFormat } } quorumFormat, err := getFormatErasureInQuorum(formats) if err != nil { t.Fatal(err) } // 16th disk is unformatted. errs[15] = errUnformattedDisk newFormats := newHealFormatSets(quorumFormat, setCount, setDriveCount, formats, errs) if newFormats == nil { t.Fatal("Unexpected failure") } // Check if deployment IDs are preserved. for i := range newFormats { for j := range newFormats[i] { if newFormats[i][j] == nil { continue } if newFormats[i][j].ID != quorumFormat.ID { t.Fatal("Deployment id in the new format is lost") } } } } func BenchmarkInitStorageDisks256(b *testing.B) { benchmarkInitStorageDisksN(b, 256) } func BenchmarkInitStorageDisks1024(b *testing.B) { benchmarkInitStorageDisksN(b, 1024) } func BenchmarkInitStorageDisks2048(b *testing.B) { benchmarkInitStorageDisksN(b, 2048) } func BenchmarkInitStorageDisksMax(b *testing.B) { benchmarkInitStorageDisksN(b, 32*204) } func benchmarkInitStorageDisksN(b *testing.B, nDisks int) { b.ResetTimer() b.ReportAllocs() fsDirs, err := getRandomDisks(nDisks) if err != nil { b.Fatal(err) } endpoints := mustGetNewEndpoints(0, 16, fsDirs...) b.RunParallel(func(pb *testing.PB) { endpoints := endpoints for pb.Next() { initStorageDisksWithErrors(endpoints, false) } }) }