// Copyright (c) 2015-2021 MinIO, Inc. // // This file is part of MinIO Object Storage stack // // This program is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // This program is distributed in the hope that it will be useful // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU Affero General Public License for more details. // // You should have received a copy of the GNU Affero General Public License // along with this program. If not, see . package cmd import ( "context" "io/ioutil" "net/http/httptest" "os" "reflect" "testing" "github.com/gorilla/mux" "github.com/minio/minio/internal/config" xnet "github.com/minio/pkg/net" ) /////////////////////////////////////////////////////////////////////////////// // // Storage REST server, storageRESTReceiver and StorageRESTClient are // inter-dependent, below test functions are sufficient to test all of them. // /////////////////////////////////////////////////////////////////////////////// func testStorageAPIDiskInfo(t *testing.T, storage StorageAPI) { testCases := []struct { expectErr bool }{ {true}, } for i, testCase := range testCases { _, err := storage.DiskInfo(context.Background()) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if err != errUnformattedDisk { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, errUnformattedDisk, err) } } } func testStorageAPIMakeVol(t *testing.T, storage StorageAPI) { testCases := []struct { volumeName string expectErr bool }{ {"foo", false}, // volume exists error. {"foo", true}, } for i, testCase := range testCases { err := storage.MakeVol(context.Background(), testCase.volumeName) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func testStorageAPIListVols(t *testing.T, storage StorageAPI) { testCases := []struct { volumeNames []string expectedResult []VolInfo expectErr bool }{ {nil, []VolInfo{{Name: ".minio.sys"}}, false}, {[]string{"foo"}, []VolInfo{{Name: ".minio.sys"}, {Name: "foo"}}, false}, } for i, testCase := range testCases { for _, volumeName := range testCase.volumeNames { err := storage.MakeVol(context.Background(), volumeName) if err != nil { t.Fatalf("unexpected error %v", err) } } result, err := storage.ListVols(context.Background()) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if !testCase.expectErr { if len(result) != len(testCase.expectedResult) { t.Fatalf("case %v: result: expected: %+v, got: %+v", i+1, testCase.expectedResult, result) } } } } func testStorageAPIStatVol(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string expectErr bool }{ {"foo", false}, // volume not found error. {"bar", true}, } for i, testCase := range testCases { result, err := storage.StatVol(context.Background(), testCase.volumeName) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if !testCase.expectErr { if result.Name != testCase.volumeName { t.Fatalf("case %v: result: expected: %+v, got: %+v", i+1, testCase.volumeName, result.Name) } } } } func testStorageAPIDeleteVol(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string expectErr bool }{ {"foo", false}, // volume not found error. {"bar", true}, } for i, testCase := range testCases { err := storage.DeleteVol(context.Background(), testCase.volumeName, false) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func testStorageAPIStatInfoFile(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", pathJoin("myobject", xlStorageFormatFile), []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string expectErr bool }{ {"foo", "myobject", false}, // file not found error. {"foo", "yourobject", true}, } for i, testCase := range testCases { _, err := storage.StatInfoFile(context.Background(), testCase.volumeName, testCase.objectName+"/"+xlStorageFormatFile) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func testStorageAPIListDir(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "path/to/myobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string prefix string expectedResult []string expectErr bool }{ {"foo", "path", []string{"to/"}, false}, // prefix not found error. {"foo", "nodir", nil, true}, } for i, testCase := range testCases { result, err := storage.ListDir(context.Background(), testCase.volumeName, testCase.prefix, -1) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if !testCase.expectErr { if !reflect.DeepEqual(result, testCase.expectedResult) { t.Fatalf("case %v: result: expected: %v, got: %v", i+1, testCase.expectedResult, result) } } } } func testStorageAPIReadAll(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "myobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string expectedResult []byte expectErr bool }{ {"foo", "myobject", []byte("foo"), false}, // file not found error. {"foo", "yourobject", nil, true}, } for i, testCase := range testCases { result, err := storage.ReadAll(context.Background(), testCase.volumeName, testCase.objectName) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if !testCase.expectErr { if !reflect.DeepEqual(result, testCase.expectedResult) { t.Fatalf("case %v: result: expected: %v, got: %v", i+1, string(testCase.expectedResult), string(result)) } } } } func testStorageAPIReadFile(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "myobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string offset int64 expectedResult []byte expectErr bool }{ {"foo", "myobject", 0, []byte("foo"), false}, {"foo", "myobject", 1, []byte("oo"), false}, // file not found error. {"foo", "yourobject", 0, nil, true}, } result := make([]byte, 100) for i, testCase := range testCases { result = result[testCase.offset:3] _, err := storage.ReadFile(context.Background(), testCase.volumeName, testCase.objectName, testCase.offset, result, nil) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } if !testCase.expectErr { if !reflect.DeepEqual(result, testCase.expectedResult) { t.Fatalf("case %v: result: expected: %v, got: %v", i+1, string(testCase.expectedResult), string(result)) } } } } func testStorageAPIAppendFile(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string data []byte expectErr bool }{ {"foo", "myobject", []byte("foo"), false}, {"foo", "myobject", []byte{}, false}, // volume not found error. {"bar", "myobject", []byte{}, true}, } for i, testCase := range testCases { err := storage.AppendFile(context.Background(), testCase.volumeName, testCase.objectName, testCase.data) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func testStorageAPIDeleteFile(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "myobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string expectErr bool }{ {"foo", "myobject", false}, // file not found not returned {"foo", "myobject", false}, // file not found not returned {"foo", "yourobject", false}, } for i, testCase := range testCases { err := storage.Delete(context.Background(), testCase.volumeName, testCase.objectName, false) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func testStorageAPIRenameFile(t *testing.T, storage StorageAPI) { err := storage.MakeVol(context.Background(), "foo") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.MakeVol(context.Background(), "bar") if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "myobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } err = storage.AppendFile(context.Background(), "foo", "otherobject", []byte("foo")) if err != nil { t.Fatalf("unexpected error %v", err) } testCases := []struct { volumeName string objectName string destVolumeName string destObjectName string expectErr bool }{ {"foo", "myobject", "foo", "yourobject", false}, {"foo", "yourobject", "bar", "myobject", false}, // overwrite. {"foo", "otherobject", "bar", "myobject", false}, } for i, testCase := range testCases { err := storage.RenameFile(context.Background(), testCase.volumeName, testCase.objectName, testCase.destVolumeName, testCase.destObjectName) expectErr := (err != nil) if expectErr != testCase.expectErr { t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr) } } } func newStorageRESTHTTPServerClient(t *testing.T) (*httptest.Server, *storageRESTClient, config.Config, string) { prevHost, prevPort := globalMinioHost, globalMinioPort defer func() { globalMinioHost, globalMinioPort = prevHost, prevPort }() endpointPath, err := ioutil.TempDir("", ".TestStorageREST.") if err != nil { t.Fatalf("unexpected error %v", err) } router := mux.NewRouter() httpServer := httptest.NewServer(router) url, err := xnet.ParseHTTPURL(httpServer.URL) if err != nil { t.Fatalf("unexpected error %v", err) } url.Path = endpointPath globalMinioHost, globalMinioPort = mustSplitHostPort(url.Host) endpoint, err := NewEndpoint(url.String()) if err != nil { t.Fatalf("NewEndpoint failed %v", endpoint) } if err = endpoint.UpdateIsLocal(); err != nil { t.Fatalf("UpdateIsLocal failed %v", err) } registerStorageRESTHandlers(router, []PoolEndpoints{{ Endpoints: Endpoints{endpoint}, }}) prevGlobalServerConfig := globalServerConfig globalServerConfig = newServerConfig() lookupConfigs(globalServerConfig, nil) restClient := newStorageRESTClient(endpoint, false) return httpServer, restClient, prevGlobalServerConfig, endpointPath } func TestStorageRESTClientDiskInfo(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIDiskInfo(t, restClient) } func TestStorageRESTClientMakeVol(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIMakeVol(t, restClient) } func TestStorageRESTClientListVols(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIListVols(t, restClient) } func TestStorageRESTClientStatVol(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIStatVol(t, restClient) } func TestStorageRESTClientDeleteVol(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIDeleteVol(t, restClient) } func TestStorageRESTClientStatInfoFile(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIStatInfoFile(t, restClient) } func TestStorageRESTClientListDir(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIListDir(t, restClient) } func TestStorageRESTClientReadAll(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIReadAll(t, restClient) } func TestStorageRESTClientReadFile(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIReadFile(t, restClient) } func TestStorageRESTClientAppendFile(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIAppendFile(t, restClient) } func TestStorageRESTClientDeleteFile(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIDeleteFile(t, restClient) } func TestStorageRESTClientRenameFile(t *testing.T) { httpServer, restClient, prevGlobalServerConfig, endpointPath := newStorageRESTHTTPServerClient(t) defer httpServer.Close() defer func() { globalServerConfig = prevGlobalServerConfig }() defer os.RemoveAll(endpointPath) testStorageAPIRenameFile(t, restClient) }