6 Commits

Author	SHA1	Message	Date
Klaus Post	6c89a81af4	Fix CreateFile shared buffer corruption. (#18652) ... `(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`. The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`, which reads into an `ODirectPool` buffer. `(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading, the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused. However, if the async `Read` call unblocks, it will write to the now recycled buffer. Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts. This is not a disk timeout, anyway. Regression in https://github.com/minio/minio/pull/17745	2023-12-14 10:51:57 -08:00
Harshavardhana	d9f1df01eb	return an error in CopyAligned upon premature EOF (#18110) ... add a unit-test to capture this corner case	2023-09-26 11:20:06 -07:00
Harshavardhana	731e03fe5a	add ReadFileStream deadline for disk call (#17745) ... timeout the reader side if hung via disk max timeout	2023-07-28 15:37:53 -07:00
Klaus Post	ff12080ff5	Remove deprecated io/ioutil (#15707)	2022-09-19 11:05:16 -07:00
Harshavardhana	f527c708f2	run gofumpt cleanup across code-base (#14015)	2022-01-02 09:15:06 -08:00
Harshavardhana	1f262daf6f	rename all remaining packages to internal/ (#12418) ... This is to ensure that there are no projects that try to import `minio/minio/pkg` into their own repo. Any such common packages should go to `https://github.com/minio/pkg`	2021-06-01 14:59:40 -07:00