1d3bd02089
avoid close 'nil' panics if any ( #18890 )
...
brings a generic implementation that
prints a stack trace for 'nil' channel
closes(), if not safely closes it.
2024-01-28 10:04:17 -08:00
c905d3fe21
fix: Re-use TCP connections for Kafka dials ( #18860 )
...
Fixes #18857
2024-01-24 13:10:52 -08:00
dd2542e96c
add codespell action ( #18818 )
...
Original work here, #18474 , refixed and updated.
2024-01-17 23:03:17 -08:00
c27d0583d4
Send kafka notification messages in batches when queue_dir is enabled ( #18164 )
...
Fixes #18124
2023-10-07 08:07:38 -07:00
4eeb48f8e0
Return cached online/offline status for audit/http loggers ( #18083 )
...
To avoid having delays in prometheus scrape and in 'mc admin info' command.
2023-09-21 16:58:24 -07:00
1c99fb106c
Update to minio/pkg/v2 ( #17967 )
2023-09-04 12:57:37 -07:00
6a8d8f34a5
kafka: Do not require key when sending a message ( #17962 )
...
Keys are helpful to ensure the strict ordering of messages, however currently the
code uses a random request id for every log, hence using the request-id
as a Kafka key is not serve any purpose;
This commit removes the usage of the key, to also fix the audit issue from
internal subsystem that does not have a request ID.
2023-09-01 08:37:22 -07:00
adb8be069e
tune-kafka targets to ensure timeout triggers on hung brokers ( #17898 )
...
hung brokers can cause slowness to the entire system
when many callers are hung, leading to large goroutine
build-up.
2023-08-22 20:26:35 -07:00
11dfc817f3
do not log client canceled events ( #17838 )
2023-08-17 14:53:43 -07:00
dbd4c2425e
fix: kafka broker pings must not be greater than 1sec ( #17376 )
2023-06-07 11:47:00 -07:00
57acacd5a7
Support persistent queue store for loggers ( #17121 )
2023-05-08 21:20:31 -07:00
8a9b9832fd
add Dial timeout for Kafka broker pings ( #17044 )
2023-04-17 15:45:01 -07:00
fb17f97cf3
move audit and logger message structure to minio/pkg ( #16655 )
...
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
2023-02-21 21:21:17 -08:00
98a67a3776
Improvements in logger and audit webhooks ( #16102 )
2022-11-28 08:03:26 -08:00
5b242f1d11
Add Audit target metrics ( #16044 )
2022-11-10 10:20:21 -08:00
5e763b71dc
use logger.LogOnce to reduce printing disconnection logs ( #15408 )
...
fixes #15334
- re-use net/url parsed value for http.Request{}
- remove gosimple, structcheck and unusued due to https://github.com/golangci/golangci-lint/issues/2649
- unwrapErrs upto leafErr to ensure that we store exactly the correct errors
2022-07-27 09:44:59 -07:00
ac055b09e9
Add detailed scanner metrics ( #15161 )
2022-07-05 14:45:49 -07:00
e952e2a691
audit/kafka: Fix quitting early after first logging ( #14932 )
...
A recent commit created some regressions:
- Kafka/Audit goroutines quit when the first log is sent
- Missing doneCh initialization in Kafka audit
2022-05-17 07:43:25 -07:00
040ac5cad8
fix: when logger queue is full exit quickly upon doneCh ( #14928 )
...
Additionally only reload requested sub-system not everything
2022-05-16 16:10:51 -07:00
472c2d828c
Fix waitgroup add after wait on config reload ( #14584 )
...
Fix `panic: "POST /minio/peer/v21/signalservice?signal=2": sync: WaitGroup is reused before previous Wait has returned`
Log entries already on the channel would cause `logEntry` to increment the
waitgroup when sending messages, after Cancel has been called.
Instead of tracking every single message, just check the send goroutine. Faster
and safe, since it will not decrement until the channel is closed.
Regression from #14289
2022-03-19 09:15:45 -07:00
3934700a08
Make audit webhook and kafka config dynamic ( #14390 )
2022-02-24 09:05:33 -08:00
28f188e3ef
Make logger webhook config dynamic ( #14289 )
...
It should not be required to restart the
server after setting the logger webhook config.
2022-02-17 11:11:15 -08:00
e316873f84
feat: Add support for kakfa audit logger target ( #12678 )
2021-07-13 09:39:13 -07:00
Harshavardhana
Praveen raj Mani
Anis Eleuch
Aditya Manthramurthy
Daniel Valdivia
Shireesh Anjal
Klaus Post