1
0
mirror of https://github.com/minio/minio.git synced 2025-01-25 21:53:16 -05:00

8 Commits

Author SHA1 Message Date
Klaus Post
ebc6c9b498
Fix tracing send on closed channel ()
Depending on when the context cancelation is picked up the handler may return and close the channel before `SubscribeJSON` returns, causing:

```
Feb 05 17:12:00 s3-us-node11 minio[3973657]: panic: send on closed channel
Feb 05 17:12:00 s3-us-node11 minio[3973657]: goroutine 378007076 [running]:
Feb 05 17:12:00 s3-us-node11 minio[3973657]: github.com/minio/minio/internal/pubsub.(*PubSub[...]).SubscribeJSON.func1()
Feb 05 17:12:00 s3-us-node11 minio[3973657]:         github.com/minio/minio/internal/pubsub/pubsub.go:139 +0x12d
Feb 05 17:12:00 s3-us-node11 minio[3973657]: created by github.com/minio/minio/internal/pubsub.(*PubSub[...]).SubscribeJSON in goroutine 378010884
Feb 05 17:12:00 s3-us-node11 minio[3973657]:         github.com/minio/minio/internal/pubsub/pubsub.go:124 +0x352
```

Wait explicitly for the goroutine to exit.

Bonus: Listen for doneCh when sending to not risk getting blocked there is channel isn't being emptied.
2024-02-06 08:57:30 -08:00
Frank Wessels
4cd777a5e0
Correct small typo in pubsub () 2024-01-31 01:01:53 -08:00
Klaus Post
6da4a9c7bb
Improve tracing & notification scalability ()
* Perform JSON encoding on remote machines and only forward byte slices.
* Migrate tracing & notification to WebSockets.
2024-01-30 12:49:02 -08:00
Harshavardhana
dd2542e96c
add codespell action ()
Original work here, ,  refixed and updated.
2024-01-17 23:03:17 -08:00
Klaus Post
71954faa3a
mark pubsub type safe via generics () 2022-10-28 10:55:42 -07:00
Klaus Post
ac055b09e9
Add detailed scanner metrics () 2022-07-05 14:45:49 -07:00
Anis Elleuch
fd02492cb7
avoid limits on the number of parallel trace/bucket notifications listeners ()
Simplifies overall limits on the incoming listeners for notifications.

Fixes 
2022-06-05 14:29:12 -07:00
Harshavardhana
1f262daf6f
rename all remaining packages to internal/ ()
This is to ensure that there are no projects
that try to import `minio/minio/pkg` into
their own repo. Any such common packages should
go to `https://github.com/minio/pkg`
2021-06-01 14:59:40 -07:00