4 Commits

Author	SHA1	Message	Date
Harshavardhana	c39eb3bacd	fix: possible crash if private.key is empty (#14208) ... Before ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x9f54f7] goroutine 1 [running]: crypto/x509.IsEncryptedPEMBlock(...) crypto/x509/pem_decrypt.go:105 github.com/minio/minio/internal/config.LoadX509KeyPair({0xc00061e270, 0x0}, {0xc00061e2d0, 0x25}) github.com/minio/minio/internal/config/certs.go:88 +0xf7 github.com/minio/pkg/certs.(*Manager).AddCertificate(0xc000576150, {0xc00061e270, 0x25}, {0xc00061e2d0, 0x25}) github.com/minio/pkg@v1.1.15/certs/certs.go:132 +0x368 github.com/minio/pkg/certs.NewManager({0x51f5910, 0xc00053e140}, {0xc00061e270, 0xc000580400}, {0xc00061e2d0, 0x25}, 0x4dc5880) github.com/minio/pkg@v1.1.15/certs/certs.go:97 +0x170 github.com/minio/minio/cmd.getTLSConfig() ``` After ``` ERROR Unable to load the TLS configuration: The private key is not readable > Please check your certificate ```	2022-01-30 12:55:21 -08:00
Harshavardhana	661b263e77	add gocritic/ruleguard checks back again, cleanup code. (#13665) ... - remove some duplicated code - reported a bug, separately fixed in #13664 - using strings.ReplaceAll() when needed - using filepath.ToSlash() use when needed - remove all non-Go style comments from the codebase Co-authored-by: Aditya Manthramurthy <donatello@users.noreply.github.com>	2021-11-16 09:28:29 -08:00
Anis Elleuch	d86513cbba	tls: Better error message when certificate curve is not supported (#13462)	2021-10-18 09:32:16 -07:00
Harshavardhana	1f262daf6f	rename all remaining packages to internal/ (#12418) ... This is to ensure that there are no projects that try to import `minio/minio/pkg` into their own repo. Any such common packages should go to `https://github.com/minio/pkg`	2021-06-01 14:59:40 -07:00