MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

trace: Fix <unknown> func name of requests rejected by max clients (#16977)

Browse Source
This commit is contained in:
Anis Eleuch 2023-04-07 15:51:12 +01:00 committed by GitHub
parent 67d2cf8f30
commit fc94ea1ced
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/handler-api.go
View File

@ -30,6 +30,7 @@ import (
"github.com/minio/minio/internal/config/api" "github.com/minio/minio/internal/config/api"
xioutil "github.com/minio/minio/internal/ioutil" xioutil "github.com/minio/minio/internal/ioutil"
"github.com/minio/minio/internal/logger" "github.com/minio/minio/internal/logger"
"github.com/minio/minio/internal/mcontext"
) )
type apiConfig struct { type apiConfig struct {
@ -272,6 +273,10 @@ func maxClients(f http.HandlerFunc) http.HandlerFunc {
globalHTTPStats.addRequestsInQueue(1) globalHTTPStats.addRequestsInQueue(1)
if tc, ok := r.Context().Value(mcontext.ContextTraceKey).(*mcontext.TraceCtxt); ok {
tc.FuncName = "s3.MaxClients"
}
deadlineTimer := time.NewTimer(deadline) deadlineTimer := time.NewTimer(deadline)
defer deadlineTimer.Stop() defer deadlineTimer.Stop()
@ -288,6 +293,10 @@ func maxClients(f http.HandlerFunc) http.HandlerFunc {
globalHTTPStats.addRequestsInQueue(-1) globalHTTPStats.addRequestsInQueue(-1)
return return
case <-r.Context().Done(): case <-r.Context().Done():
// When the client disconnects before getting the S3 handler
// status code response, set the status code to 499 so this request
// will be properly audited and traced.
w.WriteHeader(499)
globalHTTPStats.addRequestsInQueue(-1) globalHTTPStats.addRequestsInQueue(-1)
return return
} }