MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-20 18:44:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

use GenerateKey as more reliable KMS health-check (#19404)

Browse Source 
This commit replaces the `KMS.Stat` API call with a
`KMS.GenerateKey` call. This approach is more reliable
since data key generation also works when the KMS backend
is unavailable (temp. offline), but KES has cached the
key. Ref: KES offline caching.

With this change, it is less likely that MinIO readiness
checks fail in cases where the KMS backend is offline.

Signed-off-by: Andreas Auernhammer <github@aead.dev>
This commit is contained in:
Andreas Auernhammer 2024-04-03 23:13:20 +02:00 committed by GitHub
parent 97ce11cb6b
commit faeb2b7e79
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/healthcheck-handler.go
View File

@ -24,6 +24,7 @@ import (
"time" "time"
xhttp "github.com/minio/minio/internal/http" xhttp "github.com/minio/minio/internal/http"
"github.com/minio/minio/internal/kms"
) )
const unavailable = "offline" const unavailable = "offline"
@ -134,7 +135,7 @@ func ReadinessCheckHandler(w http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithTimeout(r.Context(), time.Minute) ctx, cancel := context.WithTimeout(r.Context(), time.Minute)
defer cancel() defer cancel()
if _, err := GlobalKMS.Stat(ctx); err != nil { if _, err := GlobalKMS.GenerateKey(ctx, "", kms.Context{"healthcheck": ""}); err != nil {
switch r.Method { switch r.Method {
case http.MethodHead: case http.MethodHead:
apiErr := toAPIError(r.Context(), err) apiErr := toAPIError(r.Context(), err)