MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-25 03:56:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

policy: Add Merge API (#11793)

Browse Source 
This commit adds a new API in pkg/bucket/policy package called
Merge to merge multiple policies of a user or a group into one
policy document.
This commit is contained in:
Anis Elleuch
2021-03-16 16:50:36 +01:00
committed by GitHub
parent 6160188bf3
commit fa94682e83
12 changed files with 279 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
pkg/bucket/policy/policy_test.go
View File

@@ -1144,3 +1144,97 @@ func TestPolicyValidate(t *testing.T) {
}
}
}
func TestPolicyMerge(t *testing.T) {
testCases := []struct {
policy string
}{
{`{
"Version": "2012-10-17",
"Id": "S3PolicyId1",
"Statement": [
{
"Sid": "statement1",
"Effect": "Deny",
"Principal": "*",
"Action":["s3:GetObject", "s3:PutObject"],
"Resource": "arn:aws:s3:::awsexamplebucket1/*"
}
]
}`},
{`{
"Version": "2012-10-17",
"Id": "S3PolicyId1",
"Statement": [
{
"Sid": "statement1",
"Effect": "Allow",
"Principal": "*",
"Action":"s3:GetObject",
"Resource": "arn:aws:s3:::awsexamplebucket1/*",
"Condition" : {
"IpAddress" : {
"aws:SourceIp": "192.0.2.0/24"
},
"NotIpAddress" : {
"aws:SourceIp": "192.0.2.188/32"
}
}
}
]
}`},
{`{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "cross-account permission to user in your own account",
"Effect": "Allow",
"Principal": {
"AWS": "arn:aws:iam::123456789012:user/Dave"
},
"Action": "s3:PutObject",
"Resource": "arn:aws:s3:::awsexamplebucket1/*"
},
{
"Sid": "Deny your user permission to upload object if copy source is not /bucket/folder",
"Effect": "Deny",
"Principal": {
"AWS": "arn:aws:iam::123456789012:user/Dave"
},
"Action": "s3:PutObject",
"Resource": "arn:aws:s3:::awsexamplebucket1/*",
"Condition": {
"StringNotLike": {
"s3:x-amz-copy-source": "awsexamplebucket1/public/*"
}
}
}
]
}`},
}
for i, testCase := range testCases {
var p Policy
err := json.Unmarshal([]byte(testCase.policy), &p)
if err != nil {
t.Fatalf("case %v: unexpected error: %v", i+1, err)
}
var clonedPolicy Policy
clonedPolicy = clonedPolicy.Merge(p)
j, err := json.Marshal(clonedPolicy)
if err != nil {
t.Fatalf("case %v: unexpected error: %v", i+1, err)
}
err = json.Unmarshal(j, &clonedPolicy)
if err != nil {
t.Fatalf("case %v: unexpected error: %v", i+1, err)
}
if !clonedPolicy.Statements[0].Equals(p.Statements[0]) {
t.Fatalf("case %v: different policy outcome", i+1)
}
}
}