cleanup of multipart per disk must cleanup itself only (#17223)

This commit is contained in:
Harshavardhana 2023-05-17 01:45:58 -07:00 committed by GitHub
parent 06557fe8be
commit f7d29b4a53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -201,12 +201,22 @@ func (er erasureObjects) cleanupStaleUploadsOnDisk(ctx context.Context, disk Sto
uploadIDPath := pathJoin(shaDir, uploadIDDir) uploadIDPath := pathJoin(shaDir, uploadIDDir)
fi, err := disk.ReadVersion(ctx, minioMetaMultipartBucket, uploadIDPath, "", false) fi, err := disk.ReadVersion(ctx, minioMetaMultipartBucket, uploadIDPath, "", false)
if err != nil { if err != nil {
er.deleteAll(ctx, minioMetaMultipartBucket, uploadIDPath)
return nil return nil
} }
wait := deletedCleanupSleeper.Timer(ctx) wait := deletedCleanupSleeper.Timer(ctx)
if now.Sub(fi.ModTime) > expiry { if now.Sub(fi.ModTime) > expiry {
er.deleteAll(ctx, minioMetaMultipartBucket, uploadIDPath) removeAll(pathJoin(diskPath, minioMetaMultipartBucket, uploadIDPath))
}
wait()
vi, err := disk.StatVol(ctx, pathJoin(minioMetaMultipartBucket, shaDir))
if err != nil {
return nil
}
wait = deletedCleanupSleeper.Timer(ctx)
if now.Sub(vi.Created) > expiry {
// We are not deleting shaDir recursively here, if shaDir is empty
// and its older then we can happily delete it.
Remove(pathJoin(diskPath, minioMetaMultipartBucket, shaDir))
} }
wait() wait()
return nil return nil
@ -223,7 +233,7 @@ func (er erasureObjects) cleanupStaleUploadsOnDisk(ctx context.Context, disk Sto
} }
wait := deletedCleanupSleeper.Timer(ctx) wait := deletedCleanupSleeper.Timer(ctx)
if now.Sub(vi.Created) > expiry { if now.Sub(vi.Created) > expiry {
er.deleteAll(ctx, minioMetaTmpBucket, tmpDir) removeAll(pathJoin(diskPath, minioMetaTmpBucket, tmpDir))
} }
wait() wait()
return nil return nil