config: Avoid stale credentials in memory. (#4466)

This commit is contained in:
Harshavardhana
2017-08-08 12:14:32 -07:00
committed by GitHub
parent 6f7ace3d3e
commit f346ca44f0
4 changed files with 26 additions and 7 deletions

View File

@@ -405,10 +405,13 @@ func (web *webAPIHandlers) SetAuth(r *http.Request, args *SetAuthArgs, reply *Se
errsMap := updateCredsOnPeers(creds)
// Update local credentials
serverConfig.SetCredential(creds)
prevCred := serverConfig.SetCredential(creds)
// Persist updated credentials.
if err = serverConfig.Save(); err != nil {
// Save the current creds when failed to update.
serverConfig.SetCredential(prevCred)
errsMap[globalMinioAddr] = err
}