MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-26 23:25:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Critical sections are now protected by lock

Browse Source
This commit is contained in:
Frederick F. Kautz IV 2015-04-27 19:56:48 -07:00
parent b85595addf
commit f2257a643c
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/api/quota/quota_handler.go
View File

@ -33,6 +33,8 @@ type quotaMap struct {
} }
func (q *quotaMap) CanExpire() { func (q *quotaMap) CanExpire() {
q.Lock()
defer q.Unlock()
currentMinute := time.Now().UnixNano() / q.segmentSize.Nanoseconds() currentMinute := time.Now().UnixNano() / q.segmentSize.Nanoseconds()
// divide by segmentSize, otherwise expiredQuotas will always be negative // divide by segmentSize, otherwise expiredQuotas will always be negative
expiredQuotas := currentMinute - (q.duration.Nanoseconds() / q.segmentSize.Nanoseconds()) expiredQuotas := currentMinute - (q.duration.Nanoseconds() / q.segmentSize.Nanoseconds())
@ -44,9 +46,9 @@ func (q *quotaMap) CanExpire() {
} }
func (q *quotaMap) Add(ip uint32, size int64) { func (q *quotaMap) Add(ip uint32, size int64) {
q.CanExpire()
q.Lock() q.Lock()
defer q.Unlock() defer q.Unlock()
q.CanExpire()
currentMinute := time.Now().UnixNano() / q.segmentSize.Nanoseconds() currentMinute := time.Now().UnixNano() / q.segmentSize.Nanoseconds()
if _, ok := q.data[currentMinute]; !ok { if _, ok := q.data[currentMinute]; !ok {
q.data[currentMinute] = make(map[uint32]int64) q.data[currentMinute] = make(map[uint32]int64)
@ -65,10 +67,9 @@ func (q *quotaMap) IsQuotaMet(ip uint32) bool {
} }
func (q *quotaMap) GetQuotaUsed(ip uint32) (total int64) { func (q *quotaMap) GetQuotaUsed(ip uint32) (total int64) {
currentMinute := time.Now().UnixNano() / q.segmentSize.Nanoseconds() q.CanExpire()
if _, ok := q.data[currentMinute]; !ok { q.RLock()
q.data[currentMinute] = make(map[uint32]int64) defer q.RUnlock()
}
for _, segment := range q.data { for _, segment := range q.data {
if used, ok := segment[ip]; ok { if used, ok := segment[ip]; ok {
total += used total += used