MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-05 12:20:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

allow disabling O_DIRECT for write ops (#17751)

Browse Source 
on really slow systems, O_DIRECT simply kills the drives
allow for a way to disable them.
This commit is contained in:
Harshavardhana 2023-07-29 15:17:56 -07:00 committed by GitHub
parent 9c0e8cd15b
commit f13cfcb83e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
cmd/xl-storage.go
View File

@ -284,16 +284,18 @@ func newXLStorage(ep Endpoint, cleanUp bool) (s *xlStorage, err error) {
s.formatLegacy = format.Erasure.DistributionAlgo == formatErasureVersionV2DistributionAlgoV1 s.formatLegacy = format.Erasure.DistributionAlgo == formatErasureVersionV2DistributionAlgoV1
} }
// Return an error if ODirect is not supported if !globalAPIConfig.isDisableODirect() {
// unless it is a single erasure disk mode // Return an error if ODirect is not supported
if err := s.checkODirectDiskSupport(); err == nil { // unless it is a single erasure disk mode
s.oDirect = true if err := s.checkODirectDiskSupport(); err == nil {
} else { s.oDirect = true
// Allow if unsupported platform or single disk.
if errors.Is(err, errUnsupportedDisk) && globalIsErasureSD || !disk.ODirectPlatform {
s.oDirect = false
} else { } else {
return s, err // Allow if unsupported platform or single disk.
if errors.Is(err, errUnsupportedDisk) && globalIsErasureSD || !disk.ODirectPlatform {
s.oDirect = false
} else {
return s, err
}
} }
} }
@ -1896,7 +1898,8 @@ func (s *xlStorage) writeAllDirect(ctx context.Context, filePath string, fileSiz
return osErrToFileErr(err) return osErrToFileErr(err)
} }
odirectEnabled := s.oDirect odirectEnabled := !globalAPIConfig.isDisableODirect() && s.oDirect
var w *os.File var w *os.File
if odirectEnabled { if odirectEnabled {
w, err = OpenFileDirectIO(filePath, flags, 0o666) w, err = OpenFileDirectIO(filePath, flags, 0o666)

2
internal/config/api/help.go
View File

@ -94,7 +94,7 @@ var (
}, },
config.HelpKV{ config.HelpKV{
Key: apiDisableODirect, Key: apiDisableODirect,
Description: "set to disable O_DIRECT for reads under special conditions. NOTE: it is not recommended to disable O_DIRECT without prior testing" + defaultHelpPostfix(apiDisableODirect), Description: "set to disable O_DIRECT for read and writes under special conditions. NOTE: it is not recommended to disable O_DIRECT without prior testing" + defaultHelpPostfix(apiDisableODirect),
Optional: true, Optional: true,
Type: "boolean", Type: "boolean",
}, },