Run modernize (#21546)

`go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...` executed.

`go generate ./...` ran afterwards to keep generated.

internal/bucket/replication/error.go

@@ -29,7 +29,7 @@ type Error struct {
 
 // Errorf - formats according to a format specifier and returns
 // the string as a value that satisfies error of type tagging.Error
-func Errorf(format string, a ...interface{}) error {
+func Errorf(format string, a ...any) error {
 	return Error{err: fmt.Errorf(format, a...)}
 }
 

internal/bucket/replication/replication_test.go

@@ -296,7 +296,6 @@ func TestReplicate(t *testing.T) {
 	}
 
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.opts.Name, func(t *testing.T) {
 			result := testCase.c.Replicate(testCase.opts)
 			if result != testCase.expectedResult {
@@ -352,7 +351,6 @@ func TestHasActiveRules(t *testing.T) {
 	}
 
 	for i, tc := range testCases {
-		tc := tc
 		t.Run(fmt.Sprintf("Test_%d", i+1), func(t *testing.T) {
 			cfg, err := ParseConfig(bytes.NewReader([]byte(tc.inputConfig)))
 			if err != nil {
@@ -402,7 +400,6 @@ func TestFilterActionableRules(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		cfg, err := ParseConfig(bytes.NewReader([]byte(tc.inputConfig)))
 		if err != nil {
 			t.Fatalf("Got unexpected error: %v", err)

internal/bucket/replication/rule.go

@@ -139,7 +139,7 @@ type Rule struct {
 	Destination               Destination               `xml:"Destination" json:"Destination"`
 	SourceSelectionCriteria   SourceSelectionCriteria   `xml:"SourceSelectionCriteria" json:"SourceSelectionCriteria"`
 	Filter                    Filter                    `xml:"Filter" json:"Filter"`
-	ExistingObjectReplication ExistingObjectReplication `xml:"ExistingObjectReplication,omitempty" json:"ExistingObjectReplication,omitempty"`
+	ExistingObjectReplication ExistingObjectReplication `xml:"ExistingObjectReplication,omitempty" json:"ExistingObjectReplication"`
 }
 
 var (

internal/bucket/replication/rule_test.go

@@ -57,7 +57,6 @@ func TestMetadataReplicate(t *testing.T) {
 	}
 
 	for i, tc := range testCases {
-		tc := tc
 		t.Run(fmt.Sprintf("Test_%d", i+1), func(t *testing.T) {
 			cfg, err := ParseConfig(bytes.NewReader([]byte(tc.inputConfig)))
 			if err != nil {