fix: remove all unused code (#12360)

pkg/bucket/lifecycle/lifecycle_test.go

@@ -135,12 +135,12 @@ func TestMarshalLifecycleConfig(t *testing.T) {
 			{
 				Status:     "Enabled",
 				Filter:     Filter{Prefix: Prefix{string: "prefix-1", set: true}},
-				Expiration: Expiration{Date: ExpirationDate(midnightTS)},
+				Expiration: Expiration{Date: midnightTS},
 			},
 			{
 				Status:                      "Enabled",
 				Filter:                      Filter{Prefix: Prefix{string: "prefix-1", set: true}},
-				Expiration:                  Expiration{Date: ExpirationDate(midnightTS)},
+				Expiration:                  Expiration{Date: midnightTS},
 				NoncurrentVersionTransition: NoncurrentVersionTransition{NoncurrentDays: 2, StorageClass: "TEST"},
 			},
 		},

pkg/bucket/lifecycle/rule.go

@@ -65,7 +65,7 @@ func getNewUUID() (string, error) {
 
 // validateID - checks if ID is valid or not.
 func (r Rule) validateID() error {
-	IDLen := len(string(r.ID))
+	IDLen := len(r.ID)
 	// generate new ID when not provided
 	// cannot be longer than 255 characters
 	if IDLen == 0 {