From eabfcea34e330e71dd84592dd67947f133a5be81 Mon Sep 17 00:00:00 2001
From: Harshavardhana <harsha@minio.io>
Date: Fri, 3 Aug 2018 18:57:00 -0700
Subject: [PATCH] Add granular locking in retryTicker (#6236)

This is to avoid serializing RPC contention on ongoing
parallel operations, the blocking profile indicating
all calls were being serialized through setRetryTicker.
---
 cmd/rpc.go | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/cmd/rpc.go b/cmd/rpc.go
index f0383acc9..7aacfd31b 100644
--- a/cmd/rpc.go
+++ b/cmd/rpc.go
@@ -165,6 +165,15 @@ type RPCClient struct {
 }
 
 func (client *RPCClient) setRetryTicker(ticker *time.Ticker) {
+	if ticker == nil {
+		client.RLock()
+		isNil := client.retryTicker == nil
+		client.RUnlock()
+		if isNil {
+			return
+		}
+	}
+
 	client.Lock()
 	defer client.Unlock()
 
@@ -181,18 +190,22 @@ func (client *RPCClient) Call(serviceMethod string, args interface {
 }, reply interface{}) (err error) {
 	lockedCall := func() error {
 		client.RLock()
-		defer client.RUnlock()
-
-		if client.retryTicker != nil {
+		retryTicker := client.retryTicker
+		client.RUnlock()
+		if retryTicker != nil {
 			select {
-			case <-client.retryTicker.C:
+			case <-retryTicker.C:
 			default:
 				return errRPCRetry
 			}
 		}
 
+		client.RLock()
+		authToken := client.authToken
+		client.RUnlock()
+
 		// Make RPC call.
-		args.SetAuthArgs(AuthArgs{client.authToken, client.args.RPCVersion, time.Now().UTC()})
+		args.SetAuthArgs(AuthArgs{authToken, client.args.RPCVersion, time.Now().UTC()})
 		return client.rpcClient.Call(serviceMethod, args, reply)
 	}