Introduce staticcheck for stricter builds (#7035)

pkg/s3select/sql/aggregation.go

@@ -274,10 +274,6 @@ func (e *FuncExpr) aggregateRow(r Record) error {
 // called after calling aggregateRow() on each input row, to calculate
 // the final aggregate result.
 
-func (e *Expression) getAggregate() (*Value, error) {
-	return e.evalNode(nil)
-}
-
 func (e *FuncExpr) getAggregate() (*Value, error) {
 	switch e.getFunctionName() {
 	case aggFnCount:

pkg/s3select/sql/funceval.go

@@ -234,7 +234,9 @@ func handleDateAdd(r Record, d *DateAddFunc) (*Value, error) {
 	if err != nil {
 		return nil, err
 	}
-	inferTypeAsTimestamp(ts)
+	if err = inferTypeAsTimestamp(ts); err != nil {
+		return nil, err
+	}
 	t, ok := ts.ToTimestamp()
 	if !ok {
 		return nil, fmt.Errorf("%s() expects a timestamp argument", sqlFnDateAdd)
@@ -248,7 +250,9 @@ func handleDateDiff(r Record, d *DateDiffFunc) (*Value, error) {
 	if err != nil {
 		return nil, err
 	}
-	inferTypeAsTimestamp(tval1)
+	if err = inferTypeAsTimestamp(tval1); err != nil {
+		return nil, err
+	}
 	ts1, ok := tval1.ToTimestamp()
 	if !ok {
 		return nil, fmt.Errorf("%s() expects two timestamp arguments", sqlFnDateDiff)
@@ -258,7 +262,9 @@ func handleDateDiff(r Record, d *DateDiffFunc) (*Value, error) {
 	if err != nil {
 		return nil, err
 	}
-	inferTypeAsTimestamp(tval2)
+	if err = inferTypeAsTimestamp(tval2); err != nil {
+		return nil, err
+	}
 	ts2, ok := tval2.ToTimestamp()
 	if !ok {
 		return nil, fmt.Errorf("%s() expects two timestamp arguments", sqlFnDateDiff)
@@ -363,7 +369,9 @@ func handleSQLExtract(r Record, e *ExtractFunc) (res *Value, err error) {
 		return nil, verr
 	}
 
-	inferTypeAsTimestamp(timeVal)
+	if err = inferTypeAsTimestamp(timeVal); err != nil {
+		return nil, err
+	}
 
 	t, ok := timeVal.ToTimestamp()
 	if !ok {

pkg/s3select/sql/parser.go

@@ -83,8 +83,6 @@ type Select struct {
 type SelectExpression struct {
 	All         bool                 `parser:"  @\"*\""`
 	Expressions []*AliasedExpression `parser:"| @@ { \",\" @@ }"`
-
-	prop qProp
 }
 
 // TableExpression represents the FROM clause

pkg/s3select/sql/timestampfuncs.go

@@ -38,7 +38,6 @@ var (
 		layoutSecond,
 		layoutNanosecond,
 	}
-	oneNanoSecond = 1
 )
 
 func parseSQLTimestamp(s string) (t time.Time, err error) {

pkg/s3select/sql/value.go

@@ -248,7 +248,7 @@ func (v *Value) CSVString() string {
 	case typeBool:
 		return fmt.Sprintf("%v", v.value.(bool))
 	case typeString:
-		return fmt.Sprintf("%s", v.value.(string))
+		return v.value.(string)
 	case typeInt:
 		return fmt.Sprintf("%v", v.value.(int64))
 	case typeFloat:
@@ -610,22 +610,22 @@ func (v *Value) minmax(a *Value, isMax, isFirstRow bool) error {
 	return nil
 }
 
-func inferTypeAsTimestamp(v *Value) {
+func inferTypeAsTimestamp(v *Value) error {
 	if s, ok := v.ToString(); ok {
 		t, err := parseSQLTimestamp(s)
 		if err != nil {
-			return
+			return err
 		}
 		v.setTimestamp(t)
 	} else if b, ok := v.ToBytes(); ok {
 		s := string(b)
 		t, err := parseSQLTimestamp(s)
 		if err != nil {
-			return
+			return err
 		}
 		v.setTimestamp(t)
 	}
-	return
+	return nil
 }
 
 // inferTypeAsString is used to convert untyped values to string - it