Add extensive endpoints validation (#4019)

cmd/utils.go

@@ -45,44 +45,6 @@ func cloneHeader(h http.Header) http.Header {
 	return h2
 }
 
-// checkDuplicates - function to validate if there are duplicates in a slice of strings.
-func checkDuplicateStrings(list []string) error {
-	// Empty lists are not allowed.
-	if len(list) == 0 {
-		return errInvalidArgument
-	}
-	// Empty keys are not allowed.
-	for _, key := range list {
-		if key == "" {
-			return errInvalidArgument
-		}
-	}
-	listMaps := make(map[string]int)
-	// Navigate through each configs and count the entries.
-	for _, key := range list {
-		listMaps[key]++
-	}
-	// Validate if there are any duplicate counts.
-	for key, count := range listMaps {
-		if count != 1 {
-			return fmt.Errorf("Duplicate key: \"%s\" found of count: \"%d\"", key, count)
-		}
-	}
-	// No duplicates.
-	return nil
-}
-
-// splitStr splits a string into n parts, empty strings are added
-// if we are not able to reach n elements
-func splitStr(path, sep string, n int) []string {
-	splits := strings.SplitN(path, sep, n)
-	// Add empty strings if we found elements less than nr
-	for i := n - len(splits); i > 0; i-- {
-		splits = append(splits, "")
-	}
-	return splits
-}
-
 // Convert url path into bucket and object name.
 func urlPath2BucketObjectName(u *url.URL) (bucketName, objectName string) {
 	if u == nil {
@@ -95,10 +57,11 @@ func urlPath2BucketObjectName(u *url.URL) (bucketName, objectName string) {
 
 	// Split urlpath using slash separator into a given number of
 	// expected tokens.
-	tokens := splitStr(urlPath, slashSeparator, 2)
-
-	// Extract bucket and objects.
-	bucketName, objectName = tokens[0], tokens[1]
+	tokens := strings.SplitN(urlPath, slashSeparator, 2)
+	bucketName = tokens[0]
+	if len(tokens) == 2 {
+		objectName = tokens[1]
+	}
 
 	// Success.
 	return bucketName, objectName
@@ -110,29 +73,6 @@ const (
 	httpsScheme = "https"
 )
 
-// checkDuplicates - function to validate if there are duplicates in a slice of endPoints.
-func checkDuplicateEndpoints(endpoints []*url.URL) error {
-	var strs []string
-	for _, ep := range endpoints {
-		strs = append(strs, ep.String())
-	}
-	return checkDuplicateStrings(strs)
-}
-
-// Find local node through the command line arguments. Returns in `host:port` format.
-func getLocalAddress(srvCmdConfig serverCmdConfig) string {
-	if !globalIsDistXL {
-		return srvCmdConfig.serverAddr
-	}
-	for _, ep := range srvCmdConfig.endpoints {
-		// Validates if remote endpoint is local.
-		if isLocalStorage(ep) {
-			return ep.Host
-		}
-	}
-	return ""
-}
-
 // xmlDecoder provide decoded value in xml.
 func xmlDecoder(body io.Reader, v interface{}, size int64) error {
 	var lbody io.Reader