From dc888659089f0fbfdb034cd9d783c175c42d4b64 Mon Sep 17 00:00:00 2001 From: Klaus Post Date: Tue, 28 Nov 2023 09:47:41 -0800 Subject: [PATCH] fix: shadowed error in getObjectFileInfo() (#18548) This will result in `done <- err == nil` always returning true for this path, which seems unintentional. --- cmd/erasure-object.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/erasure-object.go b/cmd/erasure-object.go index fb402c624..6e059397b 100644 --- a/cmd/erasure-object.go +++ b/cmd/erasure-object.go @@ -786,7 +786,8 @@ func (er erasureObjects) getObjectFileInfo(ctx context.Context, bucket, object s mu.Unlock() } else { // Read the latest version - ri, err := readRawFileInfo(ctx, disk, bucket, object, readData) + var ri RawFileInfo + ri, err = readRawFileInfo(ctx, disk, bucket, object, readData) mu.Lock() rawArr[i], errs[i] = ri, err mu.Unlock()