MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-07 21:02:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: reject clients that do not send proper payload (#18701)

Browse Source
This commit is contained in:
Harshavardhana
2023-12-22 01:26:17 -08:00
committed by GitHub
parent 22f8e39b58
commit da55499db0
4 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/grid/manager.go
View File

@@ -169,6 +169,7 @@ func (m *Manager) Handler() http.HandlerFunc {
msg, _, err := wsutil.ReadClientData(conn)
if err != nil {
logger.LogIf(ctx, fmt.Errorf("grid: reading connect: %w", err))
w.WriteHeader(http.StatusForbidden)
return
}
if debugPrint {
@@ -182,6 +183,7 @@ func (m *Manager) Handler() http.HandlerFunc {
fmt.Println("parse err:", err)
}
logger.LogIf(ctx, fmt.Errorf("handleMessages: parsing connect: %w", err))
w.WriteHeader(http.StatusForbidden)
return
}
if message.Op != OpConnect {
@@ -189,6 +191,7 @@ func (m *Manager) Handler() http.HandlerFunc {
fmt.Println("op err:", message.Op)
}
logger.LogIf(ctx, fmt.Errorf("handler: unexpected op: %v", message.Op))
w.WriteHeader(http.StatusForbidden)
return
}
var cReq connectReq
@@ -198,6 +201,7 @@ func (m *Manager) Handler() http.HandlerFunc {
fmt.Println("handler: creq err:", err)
}
logger.LogIf(ctx, fmt.Errorf("handleMessages: parsing ConnectReq: %w", err))
w.WriteHeader(http.StatusForbidden)
return
}
remote := m.targets[cReq.Host]
@@ -205,7 +209,7 @@ func (m *Manager) Handler() http.HandlerFunc {
if debugPrint {
fmt.Printf("%s: handler: unknown host: %v. Have %v\n", m.local, cReq.Host, m.targets)
}
logger.LogIf(ctx, fmt.Errorf("handler: unknown host: %v", cReq.Host))
w.WriteHeader(http.StatusForbidden)
return
}
if debugPrint {