Move pkg/storage/erasure to pkg/encoding/erasure - and other cleanups

pkg/storage/donut/erasure/erasure1/erasure.go

@@ -63,7 +63,7 @@ func validateHeader(header DataHeader) error {
 	return nil
 }
 
-// WriteData returns error upon any failure
+// Write returns error upon any failure
 func Write(target io.Writer, key string, part uint8, length uint32, k, m uint8, technique EncoderTechnique, data io.Reader) error {
 	header := DataHeader{
 		Key:              key,

pkg/storage/donut/fragment/fragment1/fragment.go

@@ -86,8 +86,8 @@ type DonutFrameFooter struct {
 // Data buffer
 type Data bytes.Buffer
 
-// WriteFrame - write donut format to input io.Writer, returns error upon any failure
-func WriteFrame(target io.Writer, reader io.Reader, length uint64) error {
+// Write - write donut format to input io.Writer, returns error upon any failure
+func Write(target io.Writer, reader io.Reader, length uint64) error {
 	// write header
 	header := DonutFrameHeader{
 		MagicMINI:  MagicMINI,

pkg/storage/donut/fragment/fragment1/fragment_test.go

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package fragment_test
+package fragment
 
 import (
 	"bytes"
@@ -22,7 +22,6 @@ import (
 	"encoding/binary"
 	"testing"
 
-	"github.com/minio-io/minio/pkg/storage/donut/fragment/fragment_v1"
 	"github.com/minio-io/minio/pkg/utils/checksum/crc32c"
 	. "gopkg.in/check.v1"
 )
@@ -39,7 +38,7 @@ func (s *MySuite) TestSingleWrite(c *C) {
 
 	testData := "Hello, World"
 	testLength := uint64(len(testData))
-	err := fragment.WriteFrame(&testBuffer, bytes.NewBufferString(testData), testLength)
+	err := Write(&testBuffer, bytes.NewBufferString(testData), testLength)
 	c.Assert(err, IsNil)
 
 	testBufferLength := uint64(testBuffer.Len())
@@ -112,7 +111,7 @@ func (s *MySuite) TestSingleWrite(c *C) {
 
 func (s *MySuite) TestLengthMismatchInWrite(c *C) {
 	var testData bytes.Buffer
-	err := fragment.WriteFrame(&testData, bytes.NewBufferString("hello, world"), 5)
+	err := Write(&testData, bytes.NewBufferString("hello, world"), 5)
 	c.Assert(err, Not(IsNil))
 }
 
@@ -122,7 +121,7 @@ func benchmarkSize(b *testing.B, size int) {
 	b.SetBytes(int64(size))
 	target := new(bytes.Buffer)
 	for i := 0; i < b.N; i++ {
-		fragment.WriteFrame(target, bytes.NewReader(buf[:size]), uint64(size))
+		Write(target, bytes.NewReader(buf[:size]), uint64(size))
 	}
 }
 

pkg/storage/donut/fragment/fragment_v1/.gitignore

@@ -1 +0,0 @@
-newfile