MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-09 21:49:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

posix: Deprecate custom removeAll/mkdirAll implementations. (#4808)

Browse Source 
Since go1.8 os.RemoveAll and os.MkdirAll both support long
path names i.e UNC path on windows. The code we are carrying
was directly borrowed from `pkg/os` package and doesn't need
to be in our repo anymore. As a side affect this also
addresses our codecoverage issue.

Refer #4658
This commit is contained in:
Harshavardhana
2017-08-12 19:25:43 -07:00
committed by Dee Koder
parent b69aa9c4d0
commit d864e00e24
67 changed files with 557 additions and 491 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cmd/tree-walk_test.go
View File

@@ -19,6 +19,7 @@ package cmd
import (
"fmt"
"io/ioutil"
"os"
"reflect"
"sort"
"testing"
@@ -190,7 +191,7 @@ func TestTreeWalk(t *testing.T) {
testTreeWalkPrefix(t, listDir, isLeaf)
// Simple test when marker is set.
testTreeWalkMarker(t, listDir, isLeaf)
err = removeAll(fsDir)
err = os.RemoveAll(fsDir)
if err != nil {
t.Fatal(err)
}
@@ -258,7 +259,7 @@ func TestTreeWalkTimeout(t *testing.T) {
if ok {
t.Error("Tree-walk go routine has not exited after timeout.")
}
err = removeAll(fsDir)
err = os.RemoveAll(fsDir)
if err != nil {
t.Error(err)
}
@@ -319,7 +320,7 @@ func TestListDir(t *testing.T) {
}
// Remove fsDir1 to test failover.
err = removeAll(fsDir1)
err = os.RemoveAll(fsDir1)
if err != nil {
t.Error(err)
}
@@ -335,7 +336,7 @@ func TestListDir(t *testing.T) {
if entries[0] != file2 {
t.Fatal("Expected the entry to be file2")
}
err = removeAll(fsDir2)
err = os.RemoveAll(fsDir2)
if err != nil {
t.Error(err)
}
@@ -451,7 +452,7 @@ func TestRecursiveTreeWalk(t *testing.T) {
}
}
}
err = removeAll(fsDir1)
err = os.RemoveAll(fsDir1)
if err != nil {
t.Error(err)
}
@@ -526,7 +527,7 @@ func TestSortedness(t *testing.T) {
}
// Remove directory created for testing
err = removeAll(fsDir1)
err = os.RemoveAll(fsDir1)
if err != nil {
t.Error(err)
}
@@ -601,7 +602,7 @@ func TestTreeWalkIsEnd(t *testing.T) {
}
// Remove directory created for testing
err = removeAll(fsDir1)
err = os.RemoveAll(fsDir1)
if err != nil {
t.Error(err)
}