MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-09 13:39:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

posix: Deprecate custom removeAll/mkdirAll implementations. (#4808)

Browse Source 
Since go1.8 os.RemoveAll and os.MkdirAll both support long
path names i.e UNC path on windows. The code we are carrying
was directly borrowed from `pkg/os` package and doesn't need
to be in our repo anymore. As a side affect this also
addresses our codecoverage issue.

Refer #4658
This commit is contained in:
Harshavardhana
2017-08-12 19:25:43 -07:00
committed by Dee Koder
parent b69aa9c4d0
commit d864e00e24
67 changed files with 557 additions and 491 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cmd/test-utils_test.go
View File

@@ -510,9 +510,9 @@ func newTestConfig(bucketLocation string) (rootPath string, err error) {
// Deleting the temporary backend and stopping the server.
func (testServer TestServer) Stop() {
removeAll(testServer.Root)
os.RemoveAll(testServer.Root)
for _, disk := range testServer.Disks {
removeAll(disk.Path)
os.RemoveAll(disk.Path)
}
testServer.Server.Close()
}
@@ -1646,7 +1646,7 @@ func initObjectLayer(endpoints EndpointList) (ObjectLayer, []StorageAPI, error)
// removeRoots - Cleans up initialized directories during tests.
func removeRoots(roots []string) {
for _, root := range roots {
removeAll(root)
os.RemoveAll(root)
}
}
@@ -1656,7 +1656,7 @@ func removeDiskN(disks []string, n int) {
n = len(disks)
}
for _, disk := range disks[:n] {
removeAll(disk)
os.RemoveAll(disk)
}
}
@@ -1977,7 +1977,7 @@ func ExecObjectLayerTest(t TestErrHandler, objTest objTestType) {
if err != nil {
t.Fatal("Unexpected error", err)
}
defer removeAll(rootPath)
defer os.RemoveAll(rootPath)
objLayer, fsDir, err := prepareFS()
if err != nil {
@@ -2002,7 +2002,7 @@ func ExecObjectLayerDiskAlteredTest(t *testing.T, objTest objTestDiskNotFoundTyp
if err != nil {
t.Fatal("Failed to create config directory", err)
}
defer removeAll(configPath)
defer os.RemoveAll(configPath)
objLayer, fsDirs, err := prepareXL()
if err != nil {
@@ -2024,7 +2024,7 @@ func ExecObjectLayerStaleFilesTest(t *testing.T, objTest objTestStaleFilesType)
if err != nil {
t.Fatal("Failed to create config directory", err)
}
defer removeAll(configPath)
defer os.RemoveAll(configPath)
nDisks := 16
erasureDisks, err := getRandomDisks(nDisks)