mirror of
https://github.com/minio/minio.git
synced 2025-11-09 13:39:46 -05:00
posix: Deprecate custom removeAll/mkdirAll implementations. (#4808)
Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
This commit is contained in:
committed by
Dee Koder
parent
b69aa9c4d0
commit
d864e00e24
@@ -16,14 +16,17 @@
|
||||
|
||||
package cmd
|
||||
|
||||
import "testing"
|
||||
import (
|
||||
"os"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func testAuthenticate(authType string, t *testing.T) {
|
||||
testPath, err := newTestConfig(globalMinioDefaultRegion)
|
||||
if err != nil {
|
||||
t.Fatalf("unable initialize config file, %s", err)
|
||||
}
|
||||
defer removeAll(testPath)
|
||||
defer os.RemoveAll(testPath)
|
||||
// Create access and secret keys in length, 300 and 600
|
||||
cred, err := getNewCredential(300, 600)
|
||||
if err != nil {
|
||||
@@ -90,7 +93,7 @@ func BenchmarkAuthenticateNode(b *testing.B) {
|
||||
if err != nil {
|
||||
b.Fatalf("unable initialize config file, %s", err)
|
||||
}
|
||||
defer removeAll(testPath)
|
||||
defer os.RemoveAll(testPath)
|
||||
|
||||
creds := serverConfig.GetCredential()
|
||||
b.ResetTimer()
|
||||
@@ -105,7 +108,7 @@ func BenchmarkAuthenticateWeb(b *testing.B) {
|
||||
if err != nil {
|
||||
b.Fatalf("unable initialize config file, %s", err)
|
||||
}
|
||||
defer removeAll(testPath)
|
||||
defer os.RemoveAll(testPath)
|
||||
|
||||
creds := serverConfig.GetCredential()
|
||||
b.ResetTimer()
|
||||
|
||||
Reference in New Issue
Block a user