From d602495600970254a1f485a99dd1516b68dbc497 Mon Sep 17 00:00:00 2001 From: Anis Elleuch Date: Thu, 9 Mar 2017 23:08:33 +0100 Subject: [PATCH] madmin: Do not require SSL to set credentials (#3879) We need to relax this requirement and let the client decides if it can allow to set credentials API over plain connection. --- pkg/madmin/generic-commands.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/madmin/generic-commands.go b/pkg/madmin/generic-commands.go index 9cef94275..384b74ce2 100644 --- a/pkg/madmin/generic-commands.go +++ b/pkg/madmin/generic-commands.go @@ -20,7 +20,6 @@ package madmin import ( "bytes" "encoding/xml" - "errors" "net/http" "net/url" ) @@ -34,11 +33,6 @@ type setCredsReq struct { // SetCredentials - Call Set Credentials API to set new access and secret keys in the specified Minio server func (adm *AdminClient) SetCredentials(access, secret string) error { - // Disallow sending with the server if the connection is not secure - if !adm.secure { - return errors.New("setting new credentials requires HTTPS connection to the server") - } - // Setup new request reqData := requestData{} reqData.queryValues = make(url.Values)