From d38e020b29244f4059737e8da3b5fc17b070af8c Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Wed, 22 May 2024 18:12:23 -0700 Subject: [PATCH] remove errant logs for disconnected remote (#19793) Signed-off-by: Harshavardhana --- cmd/logging.go | 4 +++- cmd/metacache-server-pool.go | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cmd/logging.go b/cmd/logging.go index b98e1be20..769486f11 100644 --- a/cmd/logging.go +++ b/cmd/logging.go @@ -17,7 +17,9 @@ func replLogOnceIf(ctx context.Context, err error, id string, errKind ...interfa } func iamLogIf(ctx context.Context, err error, errKind ...interface{}) { - logger.LogIf(ctx, "iam", err, errKind...) + if !errors.Is(err, grid.ErrDisconnected) { + logger.LogIf(ctx, "iam", err, errKind...) + } } func iamLogEvent(ctx context.Context, msg string, args ...interface{}) { diff --git a/cmd/metacache-server-pool.go b/cmd/metacache-server-pool.go index 16dcd17fe..9e637d1cf 100644 --- a/cmd/metacache-server-pool.go +++ b/cmd/metacache-server-pool.go @@ -28,6 +28,7 @@ import ( "sync" "time" + "github.com/minio/minio/internal/grid" xioutil "github.com/minio/minio/internal/ioutil" ) @@ -133,8 +134,8 @@ func (z *erasureServerPools) listPath(ctx context.Context, o *listPathOptions) ( // request canceled, no entries to return return entries, io.EOF } - if !errors.Is(err, context.DeadlineExceeded) { - // Report error once per bucket, but continue listing. + if !IsErr(err, context.DeadlineExceeded, grid.ErrDisconnected) { + // Report error once per bucket, but continue listing.x storageLogOnceIf(ctx, err, "GetMetacacheListing:"+o.Bucket) } o.Transient = true